Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBIDE-26172] latest client 6.1.1.Final fixing OpenShift 3.10 #1769

Merged
merged 1 commit into from Jul 5, 2018

Conversation

@adietish
Copy link
Member

commented Jul 5, 2018

Pull Request Checklist

General

  • Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?

Testing

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Is the non-happy path working, too?
  • Are other parts that use the same component still working fine?

Function

  • Does it work?
@adietish adietish requested review from jeffmaury and bdshadow Jul 5, 2018
@adietish adietish force-pushed the adietish:JBIDE-26172 branch from 16e0cbb to 20e27f9 Jul 5, 2018
@adietish

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2018

testPR

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish adietish force-pushed the adietish:JBIDE-26172 branch from 20e27f9 to 68125d2 Jul 5, 2018
Copy link
Member

left a comment

seems legit

@adietish adietish merged commit 0e03166 into jbosstools:master Jul 5, 2018
1 check passed
1 check passed
DCO All commits have a DCO sign-off from the author
Details
@adietish adietish deleted the adietish:JBIDE-26172 branch Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.