New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crc starting server workflow, update container runtimes #1994

Merged

jkopriva merged 1 commit into jbosstools:master from odockal:update-containers

Apr 8, 2021

Member

odockal commented Apr 7, 2021

Signed-off-by: Ondrej Dockal odockal@redhat.com

Pull Request Checklist

General

Is this a blocking issue or new feature? If yes, QE needs to +1 this PR

Code

Are method-/class-/variable-names meaningful?
Are methods concise, not too long?
Are catch blocks catching precise Exceptions only (no catch all)?

Testing

Are there unit-tests?
Are there integration tests (or at least a jira to tackle these)?
Is the non-happy path working, too?
Are other parts that use the same component still working fine?

Function

Does it work?


          Update crc starting server workflow, update container runtimes

288f20c

Signed-off-by: Ondrej Dockal <odockal@redhat.com>

odockal requested a review from jkopriva

April 7, 2021 19:31

sonarcloud bot commented Apr 7, 2021

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Member Author

odockal commented Apr 8, 2021

@jkopriva Just review, do not merge right now.

jkopriva approved these changes

View reviewed changes

jkopriva merged commit 657ee4b into jbosstools:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment