New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ssh protocol with from-code option #511

Closed

nak3 wants to merge 1 commit into jbosstools:master from unknown repository

Contributor

nak3 commented Nov 29, 2014

This patch allows url validation check for SSH protocol like "git@example.com:openshift/xxx.git".


        Support ssh protocol with from-code option

e7a8384

Contributor Author

nak3 commented Nov 29, 2014

I tested this regex with this my gist

Contributor Author

nak3 commented Nov 29, 2014

Also, please check this bz1163964 and this commit. We will not prohibit SSH protocol.

Member

adietish commented Dec 3, 2014

nice! thanks!

Contributor Author

nak3 commented Dec 3, 2014

Thanks! This will be merged?

Member

adietish commented Dec 4, 2014

yes it's on its way, I'm testing it throughoutly beforehand.

Contributor Author

nak3 commented Dec 4, 2014

Thank you so much! I will wait for it.

Member

adietish commented Dec 4, 2014

i made sure SSH Git Urls work for application template code and downloadable cartridges: #512

adietish closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.