Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBIDE-21318] use proper OpenShift version in server labels #853

Merged
merged 1 commit into from Dec 15, 2015

Conversation

@fbricon
Copy link
Member

commented Dec 15, 2015

Signed-off-by: Fred Bricon fbricon@gmail.com

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@adietish

This comment has been minimized.

Copy link
Member

commented Dec 15, 2015

+1 for the quick fix for now.

@fbricon fbricon merged commit dac3f50 into jbosstools:jbosstools-4.3.1.Beta1x Dec 15, 2015
@scabanovich

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2015

May I mention here a potential NPE in Connection.equals(). Comparing for clients goes
if (client == null) {
if (other.client != null)
return false;
} else if (!client.getBaseURL().toString().equals(other.client.getBaseURL().toString()))
return false;
When this.client is not null, other.client is not checked for null though checks above imply that it is possible.

@adietish

This comment has been minimized.

Copy link
Member

commented Dec 16, 2015

+1, goo catch, thanks!

@adietish

This comment has been minimized.

Copy link
Member

commented Dec 16, 2015

PR'ed in #856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.