Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easymport] Automatically import projects to a parent project working sets (if one exists) #31

Closed
ilx opened this issue Jan 7, 2015 · 12 comments

Comments

@ilx
Copy link
Contributor

ilx commented Jan 7, 2015

I have noticed that projects are not automatically imported into a "parent project" working set anymore.
Is it viable to make it a preference on a worspace level?
I would like to avoid wizard on "Import project" if possible.

Is this related to #29 ?

@ilx ilx changed the title Automatically import projects to a parent project working sets (if one exists) [Nestor] Automatically import projects to a parent project working sets (if one exists) Jan 7, 2015
@mickaelistria
Copy link
Contributor

Can you please give detailed steps to reproduce?

@ilx
Copy link
Contributor Author

ilx commented Jan 7, 2015

I have gradle based build:

  • execute gradle eclipse
  • import root project
  • associate root project to a working set
  • select newly created working set
  • import one of the nested projects - it's not associated to the root project working set - I have to associate it manually

@mickaelistria
Copy link
Contributor

Which procedure do you use to "import one of the nested projects". There are many ways of doing this now :)

@ilx
Copy link
Contributor Author

ilx commented Jan 7, 2015

Right click on a folder in Project explorer and select Import as Project. :)

@mickaelistria mickaelistria changed the title [Nestor] Automatically import projects to a parent project working sets (if one exists) [Easymport] Automatically import projects to a parent project working sets (if one exists) Jan 7, 2015
@mickaelistria
Copy link
Contributor

This "Import as Project" context menu action is part of Eclipse Platform UI. Cf https://bugs.eclipse.org/bugs/show_bug.cgi?id=427774 .
So you should open this request for inheritance of working sets to the Platform UI bugtracker. Please make add me as CC of the ticket once it's opened.

Closing for jbosstools-playground. If GitHub would allow ticket status, it would probably be CLOSED UPSTREAM.

@ilx
Copy link
Contributor Author

ilx commented Jan 8, 2015

Ah. I didn't spy on it. OTOH, how do I use easymport to achieve this? :)

Btw. I have updated https://bugs.eclipse.org/bugs/show_bug.cgi?id=442459

@ilx
Copy link
Contributor Author

ilx commented Jan 8, 2015

I guess I would have to use Import -> Import Projects from Folder...
The problem is that it doesn't offer me working sets. Is this a bug or I'm using too old version?

@mickaelistria
Copy link
Contributor

If you select a working set and then use "File > Import Projects from Folder", the selected working set should include the new projects.

@ilx
Copy link
Contributor Author

ilx commented Jan 8, 2015

It doesn't work for me. I have a folder structure like: xl-platform/xl-test-utils/scala-base if that matters?

xl-test-utils is just a folder/container for other projects and I really don't want it to be eclipse project (I don;t mind it when I use nested projects, but I would like to avoid it).

I have already imported xl-platform into xl-platform workingset and I have started import on xl-test-utils (with working set selected like you suggested) and it didn't work. Project was imported but not associated to the working set.

In the scenario you described I have to select folder on a disk. I already have a top level project open and expected I could right click somewhere and import visible folder as project.

Btw. do I really have to select working set? After I have started using nested projects I have only one working set enabled at the time with Top level elements -> Projects (which is a default).

@mickaelistria
Copy link
Contributor

Project was imported but not associated to the working set.

Well, that seems to be a bug. I'll try to have a look, but I've many things in my todo-list at the moment, so I can't tell when I'll be able to work on it. So if you have some time to investigate that an contribute a patch to Easymport command handler, that would be great.

Btw. do I really have to select working set? After I have started using nested projects I have only one working set enabled at the time with Top level elements -> Projects (which is a default).

Nested projects are totally independent from working sets, you don't need working sets to have nested projects. Initially the goal of nested project was exactly to get rid of working sets which are more a workaround to organize project explorer.

@mickaelistria
Copy link
Contributor

I just gave it a try, and I can confirm that as you reported, using Import Folder as Project when a working set is selected does NOT work.

@maxandersen
Copy link
Member

@mickaelistria working sets are relevant even when you have nestor IMO.

You can use workingset to group across your physical hiearchy. thus having explicit "add to working set" field would make sense imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants