JBIDE-18267 - ensure agent does not attach to newly detected jvms until ...

[robstryker]

...user connects to it in jmx view

[mmalina]

I checked this PR locally and it seems ok. The error with EAP 5.2 is gone and connection to both EAP 5.2 and EAP 6.x still works ok.

[maxandersen]

is this supposed to be default scoped ? and does it not change api that fuse uses ?

[maxandersen]

never mind - pubic is default ;) ...anyway, same question applies - does this not change api?

[robstryker]

The interface doesn't say it, but it's really not for external implementation (as far as I can tell). A grep on fuseide's source tree shows they import the interface, and use it, but no class in fuseide implements it.

Technically, yes, this is an API break. But I saw no other solution other than adding an interface method... I tried three other workarounds, but short of having jvmmonitor cast to internal IHost implementations (which is a bad idea), nothing else would have worked.

[maxandersen]

this seem to look like its changing public api in backwards incompatible way or am I reading this wrong ?

[maxandersen]

@mmalina can you reproduce the eap 5.2 error when this patch is not there ?

[robstryker]

Martin indicated to me he was able to replicate it 5 minutes before installing the locally-built units.

mmalina: yes!
strykerawb: fixed?
mmalina: I'm not that far yet - I only just verified that I can see the original issue now :) now installing your PR

[mmalina]

@maxandersen yes, I could reproduce the error before I applied this patch. And then when I installed it, the problem disappeared.