Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upJBIDE-18863 - browse button causes wrong separators in deployment pref UI #311
Conversation
....ui/jbossui/org/jboss/ide/eclipse/as/ui/editor/internal/JBossDeploymentOptionsComposite.java
Outdated
| protected char getSeparatorCharacter(IServer server) { | ||
| // Discover the proper separator character for the paths being used | ||
| char sep = File.separatorChar; | ||
| IControllableServerBehavior beh = JBossServerBehaviorUtils.getControllableBehavior(server); |
This comment has been minimized.
This comment has been minimized.
fbricon
Dec 3, 2014
Member
How about reducing the code by calling getController instead? See https://github.com/jbosstools/jbosstools-server/blob/master/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/JBossServerBehaviorUtils.java#L63
| return makeRelative(path, getPage().getServer().getRuntime()); | ||
| } | ||
|
|
||
| private static String makeRelative(String path, IRuntime runtime) { | ||
| return ServerUtil.makeRelative(runtime, new Path(path)).toString(); | ||
| return ServerUtil.makeRelative(runtime, new Path(path)).toOSString(); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
robstryker
Dec 3, 2014
Author
Member
If remote OS is different from local, that's handled 5 lines above: if separators are different from local, do not modify the path at all.
robstryker
force-pushed the
robstryker:JBIDE-18863
branch
4 times, most recently
from
f731a52
to
009e2c2
|
+1 to apply, after squashing the commits |
…f UI JBIDE-18863 - fix a missing toOSString() in the deployment scanner additions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
robstryker commentedDec 3, 2014
No description provided.