Eap XP - dev watch - launch action added to astools #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Stryker <rob@oxbeef.net>
jeffmaury
requested changes
Jan 26, 2022
| IProgressMonitor monitor) throws CoreException { | ||
| waitForPortAvailable(port, monitor); | ||
| IProject project = getProject(configuration); | ||
| String name = "EapXP remote " + project.getName(); |
There was a problem hiding this comment.
Should be rename as Standalone web application ....
| public static ILaunch run(IProject project, String profile, int debugPort, IProgressMonitor monitor) throws CoreException { | ||
| ILaunchConfigurationWorkingCopy launchConfiguration = getConfiguration(project); | ||
| launchConfiguration.setAttribute(MavenLaunchConstants.ATTR_GOALS, "package quarkus:dev"); | ||
| if (StringUtils.isBlank(profile)) { |
There was a problem hiding this comment.
This part is specific to Quarkus should be update to the Wildfly plugin
| import org.jboss.tools.common.jdt.core.buildpath.ClasspathContainersHelper; | ||
|
|
||
| public class ProjectUtils { | ||
| /* |
| public static boolean isJBossXpProject(IJavaProject javaProject) { | ||
| IMavenProjectFacade facade = MavenPlugin.getMavenProjectRegistry().create( javaProject.getProject(), new NullProgressMonitor() ); | ||
| try { | ||
| Plugin plugin = facade.getMavenProject(new NullProgressMonitor()).getPlugin("org.wildfly.plugins:wildfly-jar-maven-plugin"); |
There was a problem hiding this comment.
What if facade is null (ie not a Maven project)
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Signed-off-by: Rob Stryker <rob@oxbeef.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rob Stryker rob@oxbeef.net
Pull Request Checklist
General
Code
Testing
Function