JIBDE-12860 - JAX-RS validation problems are not linked #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * element matched in the metamodel. | ||
| * @throws JavaModelException | ||
| */ | ||
| private List<IJaxrsElement> searchJaxrsElements(final IJavaElement element) throws JavaModelException { | ||
| private Collection <IJaxrsElement> searchJaxrsElements(final IJavaElement element) throws JavaModelException { |
There was a problem hiding this comment.
why the change ? should clients now assume ordering is not deterministic or?
|
+1 for change since internal and cleans up marker handling quite a bit |
Fixed the problem where some markers would not be removed from the resource to be validated between two validation calls, which meant that duplicate markers for the same problem would exist on each resource. Also refactored the search/element retrieval: the JaxrsElementIndexationDelegate now not only deals with the Lucene indexation and searches, but also uses the metamodel to return List of JAX-RS elements, Endpoints or workspace Resources. Renamed some marker deletion/undexing methods to use the "remove" verb (eg: "removeMarker()") and be consistent with the existing "remove()" methods that remove the elements themselves. Added JUnit tests to covers the fixes. This patch also fixes: - JBIDE-15662: Warning Multiple JAX-RS Activators doesn't disappear - JBIDE-15664: Application path configured in web.xml causes warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem where some markers would not be removed from the resource to be validated between
two validation calls, which meant that duplicate markers for the same problem would exist on each
resource.
Also refactored a bit the search/element retrieval: the JaxrsElementIndexationDelegate now not only
deals with the Lucene indexation and searches, but also uses the metamodel to return collections of
JAX-RS elements, Endpoints or workspace Resources. Although this does not break the public API, the change
from List/Set to Collection impled a few changes in the JUnit tests as well.
Added JUnit tests to covers the fixes.
This patch also fixes: