Skip to content

/ jbosstools-website

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create servers_deployapptolocalserver.adoc #292

Closed
wants to merge 1 commit into from
Closed

Create servers_deployapptolocalserver.adoc #292

wants to merge 1 commit into from

Conversation

@aasingh
Copy link
Contributor

aasingh commented Dec 8, 2014

No description provided.

@aasingh
Create servers_deployapptolocalserver.adoc
Loading status checks…
edd83ba
@xcoulon
Copy link
Member

xcoulon commented Dec 8, 2014

@robstryker, can you review this PR, then I'll merge it.
Thanks !
documentation/howto/servers_deployapptolocalserver.adoc

. In the table of located runtimes, ensure the runtime is selected and click *OK*.

. Click 8Apply* and click *OK* to close the *Preferences* window.

This comment has been minimized.

Sign in to view
Copy link
@robstryker

robstryker Dec 8, 2014

Member

Rogue 8
@robstryker
Copy link
Member

robstryker commented Dec 8, 2014

looks good if you fix that 8
@aasingh
Copy link
Contributor Author

aasingh commented Dec 8, 2014

I need to make further changes to the article so i will create a new PR and then close the PR.
@maxandersen
Copy link
Member

maxandersen commented Dec 8, 2014

@assingh you do not need to close this PR, you can just commit and push to your "patch-1" branch and this PR will be updated automatically.
@aasingh
Copy link
Contributor Author

aasingh commented Dec 9, 2014

Thanks Max,
The "pathch-1" branch was not the correct naming convention so I had to create a new branch and commit the file there.
I have made the changes to the new branch "TOOLSDOC-557".
Can i still go ahead and close the PR?
Apologies for the inconvenience.

Link to the new PR: #294
@maxandersen
Copy link
Member

maxandersen commented Dec 9, 2014

yeah sure we can close this -just wanted to be sure you weren't reopening new one because you didnt think you could update this one. closing!
@maxandersen maxandersen closed this Dec 9, 2014
@michellemurray michellemurray mentioned this pull request Dec 11, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@aasingh @xcoulon @robstryker @maxandersen
You can’t perform that action at this time.