Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.adoc #296

Closed
wants to merge 1 commit into from
Closed

Update index.adoc #296

wants to merge 1 commit into from

Conversation

@aasingh
Copy link
Contributor

aasingh commented Dec 9, 2014

Added links for,

  1. Create Your First Mobile Web App

Link to PR: #295

  1. Deploy Apps to a Local Server

Link to PR: #294

Added links for, 
1. Create Your First Mobile Web App
2. Deploy Apps to a Local Server
@aasingh
Copy link
Contributor Author

aasingh commented Dec 9, 2014

please merge the changes.

@xcoulon
Copy link
Member

xcoulon commented Dec 10, 2014

@aasingh, we should merge all 3 PRs (this one + #294 and #295) at once, but as far as I can see, #294 still needs to be reviewed by @robstryker and @kmarmaliykov gave some feedback on #295 so this PR may need to be updated.
Let me know when the 2 linked PR are ready and I'll take care of all 3 at once.

@michellemurray
Copy link
Contributor

michellemurray commented Dec 11, 2014

@xcoulon - the other 2 are ready now so please merge this one too

@kmarmaliykov
Copy link
Contributor

kmarmaliykov commented Dec 11, 2014

@michellemurray I also add one more comment in Jira about #295 Please check if it is necessary to add(I think yes, it is necessary)

@michellemurray
Copy link
Contributor

michellemurray commented Dec 15, 2014

@xcoulon - I think you have already merged this one on Friday 12-Dec so it should be closed, right?

@xcoulon
Copy link
Member

xcoulon commented Dec 15, 2014

@michellemurray, right, the issue was not automatically marked as 'merged' because I rebased the commit.
Closing it now.
Thanks !

@xcoulon xcoulon closed this Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.