Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBQA-11309: Incorporating QE feedback to Deploy Apps to local Server #317

Closed
wants to merge 1 commit into from

Conversation

@aasingh
Copy link
Contributor

aasingh commented Dec 17, 2014

Incorporating QE feedback for JBQA-11309. Please refrain from merging this PR until QE team approves this.

@xcoulon
Copy link
Member

xcoulon commented Dec 17, 2014

@aasingh, the .adoc file in the PR is not in the /documentation/howto folder, and I think you should include a link to it in /documentation/howto/index.adoc, too.

@xcoulon
Copy link
Member

xcoulon commented Dec 17, 2014

@aasingh feel free to ping me on IRC if you need help with updating the PR ;-)

@aasingh aasingh force-pushed the aasingh:JBQA-11309 branch from d47ea9a to 7936a01 Dec 17, 2014
@xcoulon
Copy link
Member

xcoulon commented Dec 17, 2014

@aasingh, oh my bad, now that your PR modifies refers to the file in its correct location, I can see that it's a modification of an existing file, not a new file. So there's actually no need to add anything in /documentation/howto/index.adoc ;-)

@xcoulon
Copy link
Member

xcoulon commented Dec 17, 2014

@aasingh please, notify me when QE approved the PR ;-)

@aasingh
Copy link
Contributor Author

aasingh commented Dec 17, 2014

@xcoulon - no worries, I admit that I was little confused when you asked me to update the index.adoc. But I refrained from updating :).
Thanks for all your assistance, I was able to make the changes :)

@xcoulon
Copy link
Member

xcoulon commented Dec 17, 2014

@aasingh you were right not to change index.adoc ;-) (I should have looked more carefully at the file name to see that it was an update to an existing doc, not a new one)

@mmalina
Copy link
Member

mmalina commented Dec 18, 2014

Approved. You can merge the PR.

@xcoulon
Copy link
Member

xcoulon commented Dec 18, 2014

PR merged. Thanks, @aasingh and @mmalina !

@xcoulon xcoulon closed this Dec 18, 2014
mmalina added a commit to mmalina/jbosstools-website that referenced this pull request Jun 11, 2015
I just noticed there was a long standing JIRA to review this doc.
A change was proposed here:
jbosstools#317
But for some reason this one sentence fix is not currently in master.
So fixing now.
mmalina added a commit that referenced this pull request Jun 17, 2015
I just noticed there was a long standing JIRA to review this doc.
A change was proposed here:
#317
But for some reason this one sentence fix is not currently in master.
So fixing now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.