Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upJBQA-11309: Incorporating QE feedback to Deploy Apps to local Server #317
Conversation
|
@aasingh, the .adoc file in the PR is not in the /documentation/howto folder, and I think you should include a link to it in /documentation/howto/index.adoc, too. |
|
@aasingh feel free to ping me on IRC if you need help with updating the PR ;-) |
|
@aasingh, oh my bad, now that your PR modifies refers to the file in its correct location, I can see that it's a modification of an existing file, not a new file. So there's actually no need to add anything in /documentation/howto/index.adoc ;-) |
|
@aasingh please, notify me when QE approved the PR ;-) |
|
@xcoulon - no worries, I admit that I was little confused when you asked me to update the index.adoc. But I refrained from updating :). |
|
@aasingh you were right not to change index.adoc ;-) (I should have looked more carefully at the file name to see that it was an update to an existing doc, not a new one) |
|
Approved. You can merge the PR. |
I just noticed there was a long standing JIRA to review this doc. A change was proposed here: jbosstools#317 But for some reason this one sentence fix is not currently in master. So fixing now.
aasingh commentedDec 17, 2014
Incorporating QE feedback for JBQA-11309. Please refrain from merging this PR until QE team approves this.