New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror repository URLs should permit dots in repository path #311

Closed
lelutin opened this Issue Nov 13, 2014 · 0 comments

Comments

Projects
None yet
2 participants
@lelutin

lelutin commented Nov 13, 2014

currently in app/models/repository_mirror.rb the regex used for validating mirror URL doesn't accept dots in the repository path. having dots in dir/file names is a common thing in *nix systems so the mirror URL regex should accept them.

this part of the regex: ([\w\/\-~]+)(\.git)

should be adapted to: ([\w\/\-\.~]+)(\.git)

@n-rodriguez n-rodriguez added the bug label Dec 20, 2014

@n-rodriguez n-rodriguez self-assigned this Dec 20, 2014

@n-rodriguez n-rodriguez added this to the v0.8 milestone Dec 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment