New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitolite_config_file not being created in sub-directory #335

Closed
FlorianMuenchbach opened this Issue Jan 28, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@FlorianMuenchbach

FlorianMuenchbach commented Jan 28, 2015

Hi Nicolas,

first of all, thanks for your support on my other issue. And for the plugin of course ;)
v1.0.0 works like a charm!

I have found another problem. It's not critical, but may lead to some kind of frustration when configuring the plugin.

I have set gitolite_config_file to incl/redmine.conf, gitolite_config_has_admin_key is set to false.
The directory "incl" exists in gitolite-admin.git/conf. There is another file in it, so git wouldn't delete it as an empty directory.

When the plugin updates the configuration, a config file is correctly written directly in gitolite-admin.git/conf. This file is not being added to git but I can see it in the tmp directory.
git status in the plugin's temporary copy shows it as new even after multiple re-syncs.
The plugin complains that it does not find the file, I guess when trying to add the correct path to git (correct as in configured in the frontend):

[...]
[INFO] update_projects : repository 'redmine_repos/test' does not exist in Gitolite, create it ...
[INFO] update_projects : commiting to Gitolite...
[ERROR] Could not find '/tmp/redmine_git_hosting/git/gitolite-admin.git/conf/incl/redmine.conf' to stat: No such file or directory

When I remove the subdirectory from the path in the frontend, the config file is being created directly under gitolite-admin.git/conf and being added to git correctly.
I can live with that, but you maybe want to add a note in the wiki somewhere, too.

This issue might cause some of the behavior mentioned in #327. I can't verify it, since I don't have the old branch anymore.

@n-rodriguez n-rodriguez added the bug label Feb 8, 2015

@n-rodriguez n-rodriguez self-assigned this Feb 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment