New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

503 error on settings page: ActionView::Template::Error (undefined method `split' for nil:NilClass) #351

Closed
anarcat opened this Issue Feb 4, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@anarcat

anarcat commented Feb 4, 2015

after trying to follow the upgrade procedures to go from something like an old 0.4 to 0.7.10 here:

http://jbox-web.github.io/redmine_git_hosting/howtos/migrate/#

... things were going pretty well until i fixed the "git user" field in the preferences to talk to gitolite properly (from git to gitolite). then the /settings/plugin/redmine_git_hosting path gives me:

Started GET "/settings/plugin/redmine_git_hosting" for X at 2015-02-04 17:36:20 -0500
Processing by SettingsController#plugin as HTML
  Parameters: {"id"=>"redmine_git_hosting"}
  Current user: Y (id=3)
  Rendered plugins/redmine_git_hosting/app/views/settings/_gitolite_config_ssh.html.erb (116.6ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_gitolite_config_storage.html.erb (658.2ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_gitolite_config_file.html.erb (1.3ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_gitolite_config_global.html.erb (113.1ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_gitolite_config_access.html.erb (2.0ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_gitolite_config_hooks.html.erb (1.1ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_gitolite_config_cache.html.erb (0.6ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_gitolite_config_notify.html.erb (1.1ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_gitolite_display_access.html.erb (0.9ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_redmine_config.html.erb (2.6ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_sidekiq_interface.html.erb (0.3ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_gitolite_config_test.html.erb (5786.8ms)
  Rendered common/_tabs.html.erb (6690.7ms)
  Rendered plugins/redmine_git_hosting/app/views/settings/_redmine_git_hosting.html.erb (6693.2ms)
  Rendered settings/plugin.html.erb within layouts/admin (6694.0ms)
Completed 500 Internal Server Error in 6698.2ms

ActionView::Template::Error (undefined method `split' for nil:NilClass):
    68:   </tr>
    69:
    70:
    71:   <% gitolite_checks = RedmineGitolite::HookManager.check_install! %>
    72:
    73:   <tr>
    74:     <td><%= l(:label_gitolite_hooks_params_installed) %></td>
  app/views/common/_tabs.html.erb:22:in `block in _app_views_common__tabs_html_erb___224549082141810226_70141840'
  app/views/common/_tabs.html.erb:21:in `each'
  app/views/common/_tabs.html.erb:21:in `_app_views_common__tabs_html_erb___224549082141810226_70141840'
  app/helpers/application_helper.rb:318:in `render_tabs'
  app/views/settings/plugin.html.erb:6:in `block in _app_views_settings_plugin_html_erb___2076124447911929339_69708500'
  app/views/settings/plugin.html.erb:4:in `_app_views_settings_plugin_html_erb___2076124447911929339_69708500'

this makes the plugin basically unusable. i tried to update to v1.0.0, but failed because of #339 (comment)

@anarcat

This comment has been minimized.

Show comment
Hide comment
@anarcat

anarcat Feb 4, 2015

this goes away if i remove the banner on the SSH server which gets showed always, it's a "cat" in /etc/profile.d that breaks everything...

anarcat commented Feb 4, 2015

this goes away if i remove the banner on the SSH server which gets showed always, it's a "cat" in /etc/profile.d that breaks everything...

@n-rodriguez n-rodriguez self-assigned this Feb 4, 2015

@n-rodriguez n-rodriguez added the bug label Feb 4, 2015

@n-rodriguez n-rodriguez modified the milestones: v1.1.0, 1.0.1 Feb 4, 2015

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Feb 25, 2015

Member

This is a partial fix : it only avoids "undefined method `split' for nil:NilClass" error.

Actually the "cat" sends data on stdout when installing hook files which breaks the "sudo pipe".

I can only advise you to remove the "cat" for the Git user.

Member

n-rodriguez commented Feb 25, 2015

This is a partial fix : it only avoids "undefined method `split' for nil:NilClass" error.

Actually the "cat" sends data on stdout when installing hook files which breaks the "sudo pipe".

I can only advise you to remove the "cat" for the Git user.

@n-rodriguez n-rodriguez added this to the v1.0.2 milestone Feb 25, 2015

@anarcat

This comment has been minimized.

Show comment
Hide comment
@anarcat

anarcat Feb 25, 2015

yep, we did remove that, but the point here was to recover more gracefully in case of garbled output.

anarcat commented Feb 25, 2015

yep, we did remove that, but the point here was to recover more gracefully in case of garbled output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment