New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Redmine 3.0.0 #354

Closed
Trim opened this Issue Feb 8, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@Trim

Trim commented Feb 8, 2015

Hello,

Last week I've upgraded my server to Debian Jessie and I was surprised that Redmine version is the not already released 3.0.0. As this plugin is really useful, I want to help to port it to Redmine 3.0.0 (certainly on a virtual machine first) if I'm able.

The only informations I've found about Redmine 3.0.0 is their roadmap which say the release is due in 14 days. I'll try to view code in their trunk svn repository to see if I can find some clue about big changes.

While upgrading Debian, I've noticed these incompatible gems:

  • gem "redcarpet", "~> 3.1.2"
  • the rack gem version (I think implied by the gem "rails", "4.2.0" line) which conflicts with your gitlab-grack repo. I've seen a new pre-version of gitlab-grack 2.0.0 which appears have no more conflict

I'll investigate to find which SQL table have been modified since 2.6.1. Which SQL structures do you need for your plugin ?

Hope I can help,
Adrien

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Feb 8, 2015

Member

Last week I've upgraded my server to Debian Jessie and I was surprised that Redmine version is the not already released 3.0.0.

This is not very surprising due to the Debian release policy. The package tree is freezed since 3 or 4 months. (https://release.debian.org/jessie/freeze_policy.html)

Member

n-rodriguez commented Feb 8, 2015

Last week I've upgraded my server to Debian Jessie and I was surprised that Redmine version is the not already released 3.0.0.

This is not very surprising due to the Debian release policy. The package tree is freezed since 3 or 4 months. (https://release.debian.org/jessie/freeze_policy.html)

@n-rodriguez n-rodriguez self-assigned this Feb 8, 2015

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Feb 8, 2015

Member

I want to help to port it to Redmine 3.0.0

Thanks for your help but I think there won't be too much work to port it to Redmine 3.0.0 :)

Member

n-rodriguez commented Feb 8, 2015

I want to help to port it to Redmine 3.0.0

Thanks for your help but I think there won't be too much work to port it to Redmine 3.0.0 :)

@n-rodriguez n-rodriguez added the question label Feb 8, 2015

@Trim

This comment has been minimized.

Show comment
Hide comment
@Trim

Trim Feb 9, 2015

So, I've begun work here Trim/redmine_git_hosting and I've found this bug due to Rails4 and Postgresql during install:

== 20130909195929 RenameTableDeploymentCredentials: migrating =================
-- rename_table(:deployment_credentials, :repository_deployment_credentials)
rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

Input string is longer than NAMEDATALEN-1 (63)/usr/share/redmine/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/postgresql/quoting.rb:170:in `quote_ident'

I think the solution to rename the auto keys or tables isn't possible for already in production migration database files. The issue is that to modify NAMEDATALEN value we have to recompile PostgreSQL.

Trim commented Feb 9, 2015

So, I've begun work here Trim/redmine_git_hosting and I've found this bug due to Rails4 and Postgresql during install:

== 20130909195929 RenameTableDeploymentCredentials: migrating =================
-- rename_table(:deployment_credentials, :repository_deployment_credentials)
rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

Input string is longer than NAMEDATALEN-1 (63)/usr/share/redmine/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/postgresql/quoting.rb:170:in `quote_ident'

I think the solution to rename the auto keys or tables isn't possible for already in production migration database files. The issue is that to modify NAMEDATALEN value we have to recompile PostgreSQL.

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Feb 9, 2015

Member

I think the solution to rename the auto keys or tables isn't possible for already in production migration database files. The issue is that to modify NAMEDATALEN value we have to recompile PostgreSQL.

From what I see on StackOverflow it can be an index name :

Most likely it is an index name which is hitting the character limit.

One solution would be to remove indexes before renaming the table.

Member

n-rodriguez commented Feb 9, 2015

I think the solution to rename the auto keys or tables isn't possible for already in production migration database files. The issue is that to modify NAMEDATALEN value we have to recompile PostgreSQL.

From what I see on StackOverflow it can be an index name :

Most likely it is an index name which is hitting the character limit.

One solution would be to remove indexes before renaming the table.

@n-rodriguez n-rodriguez added this to the v1.0.2 milestone Feb 24, 2015

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Feb 25, 2015

Member

Everything has been fixed here and here :)

Member

n-rodriguez commented Feb 25, 2015

Everything has been fixed here and here :)

@Trim

This comment has been minimized.

Show comment
Hide comment
@Trim

Trim Feb 25, 2015

Many thanks, I'll try it this afternoon :)

Trim commented Feb 25, 2015

Many thanks, I'll try it this afternoon :)

@Trim

This comment has been minimized.

Show comment
Hide comment
@Trim

Trim Feb 25, 2015

Ok, it worked for me after little tweaking of Debian Jessie default redmine Gemfile (just commented the constraint on rails version which were in conflict with grack [they've set it to ~>4.1.4]).

Trim commented Feb 25, 2015

Ok, it worked for me after little tweaking of Debian Jessie default redmine Gemfile (just commented the constraint on rails version which were in conflict with grack [they've set it to ~>4.1.4]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment