New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Git cache] "Until next commit" param is broken #401

Closed
niosHD opened this Issue Mar 28, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@niosHD

niosHD commented Mar 28, 2015

After the last upgrade of my installation I noticed that the cache seems to be broken. Opening any repository took ages. However, I think I found the issue.

The gitolite_cache_max_time value for "Disabled" is 0 and for "until next commit" is -1.
The check for git_cache_enabled? in the xitolite_adapter checks for > 0 which means that "until next commit" is treated as disabled.

I therefore tried RedmineGitHosting::Config.gitolite_cache_max_time != 0 which seems to fix the issue.

regards

@n-rodriguez n-rodriguez self-assigned this Mar 30, 2015

@n-rodriguez n-rodriguez added the bug label Mar 30, 2015

@n-rodriguez n-rodriguez added this to the v1.0.3 milestone Mar 30, 2015

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Mar 30, 2015

Member

Good point for you! Thank you!

Member

n-rodriguez commented Mar 30, 2015

Good point for you! Thank you!

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Mar 30, 2015

Member

By the way which cache adapter do you use?

Member

n-rodriguez commented Mar 30, 2015

By the way which cache adapter do you use?

@n-rodriguez n-rodriguez changed the title from Git cache "Until next commit" broken to [Git cache] "Until next commit" param is broken Mar 30, 2015

@niosHD

This comment has been minimized.

Show comment
Hide comment
@niosHD

niosHD Mar 31, 2015

Your welcome! I am currently still using the database cache adapter, but mainly because it has been used before. What are the advantages of the new adapters?

niosHD commented Mar 31, 2015

Your welcome! I am currently still using the database cache adapter, but mainly because it has been used before. What are the advantages of the new adapters?

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Mar 31, 2015

Member

What are the advantages of the new adapters?

They are faster :)

Member

n-rodriguez commented Mar 31, 2015

What are the advantages of the new adapters?

They are faster :)

@niosHD

This comment has been minimized.

Show comment
Hide comment
@niosHD

niosHD Mar 31, 2015

good to know, I'll give them a try ;)
thanks for working on this awesome plugin!

niosHD commented Mar 31, 2015

good to know, I'll give them a try ;)
thanks for working on this awesome plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment