New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Git cache] "Until next commit" param is broken for Redis adapter #404

Closed
niosHD opened this Issue Apr 1, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@niosHD

niosHD commented Apr 1, 2015

I just tried the redis cache adapter like suggested in #401 and noticed that until next commit is broken there too. Insertion into redis fails with the following error.

[ERROR] Redis Adapter : could not insert in cache, this is the error : 'ERR invalid expire time in SETEX'

I suspect that it is again related to the -1 encoding of gitolite_cache_max_time. Redis seems not too happy when -1 is specified as timeout.

Using any other timeout seems to work fine and is really blazing fast. Great job!

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Apr 1, 2015

Member

Hi! Thanks for your feedback! I will take a look when I'll be less busy :)

Member

n-rodriguez commented Apr 1, 2015

Hi! Thanks for your feedback! I will take a look when I'll be less busy :)

@n-rodriguez n-rodriguez self-assigned this Apr 1, 2015

@n-rodriguez n-rodriguez added the bug label Apr 1, 2015

@n-rodriguez n-rodriguez added this to the v1.0.4 milestone Apr 1, 2015

@n-rodriguez n-rodriguez changed the title from [Git cache] "Until next commit" param is broken for redis to [Git cache] "Until next commit" param is broken for Redis adapter Apr 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment