New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH/Gitolite server host on 1.2 #541

Closed
madorin opened this Issue Nov 21, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@madorin

madorin commented Nov 21, 2015

Hello,

After successful upgrade to 1.2, pressing in Config [Apply] button it says that "SSH/Gitolite server host" is invalid (it is set to default value as "localhost"). Setting it to 127.0.0.1, config was accepted.
It seems that it accepts IPs only, strange. Tried with different values, IPs and hostnames.

Thanks!

@dgeo

This comment has been minimized.

Show comment
Hide comment
@dgeo

dgeo Nov 22, 2015

Same here: I looked in the code, and it MUST be an IP(v4) address. Dunno if the code have to be changed here (I'd prefer) to accept hostnames, or if admin interface should precise 'SSH/Gitolite server IP(v4)' …
My 2 cts…

dgeo commented Nov 22, 2015

Same here: I looked in the code, and it MUST be an IP(v4) address. Dunno if the code have to be changed here (I'd prefer) to accept hostnames, or if admin interface should precise 'SSH/Gitolite server IP(v4)' …
My 2 cts…

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Nov 22, 2015

Member

Same here: I looked in the code, and it MUST be an IP(v4) address. Dunno if the code have to be changed here (I'd prefer) to accept hostnames, or if admin interface should precise 'SSH/Gitolite server IP(v4)' …

Yep. I chose to fill the field with an IP because of :

  • validation (easier to valid an IP adress than a domain name)
  • there is no vhost concept in SSH so domain is useless (except for DNS update, but you don't move your Gitolite server every day ;)).
Member

n-rodriguez commented Nov 22, 2015

Same here: I looked in the code, and it MUST be an IP(v4) address. Dunno if the code have to be changed here (I'd prefer) to accept hostnames, or if admin interface should precise 'SSH/Gitolite server IP(v4)' …

Yep. I chose to fill the field with an IP because of :

  • validation (easier to valid an IP adress than a domain name)
  • there is no vhost concept in SSH so domain is useless (except for DNS update, but you don't move your Gitolite server every day ;)).

@n-rodriguez n-rodriguez self-assigned this Nov 22, 2015

@madorin

This comment has been minimized.

Show comment
Hide comment
@madorin

madorin Nov 23, 2015

I think it should accept host names beside of IPs.
It give more flexibility, especially on changes, migrations.
SSH connect functions require "host" parameter. It can be an IP or a NAME.
Why limit it just to IPv4? v6 is much closer than it looks ;)
Best "validation" is trying to connect to user specified host, instead of just validating IP.

madorin commented Nov 23, 2015

I think it should accept host names beside of IPs.
It give more flexibility, especially on changes, migrations.
SSH connect functions require "host" parameter. It can be an IP or a NAME.
Why limit it just to IPv4? v6 is much closer than it looks ;)
Best "validation" is trying to connect to user specified host, instead of just validating IP.

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Nov 26, 2015

Member

I think it should accept host names beside of IPs.

Well this sounds difficult as '12345.36.70.fr' is a valid hostname and an invalid IPv4 or IPv6.
I think I'm gonna rollback to hostname and only hostname.

Member

n-rodriguez commented Nov 26, 2015

I think it should accept host names beside of IPs.

Well this sounds difficult as '12345.36.70.fr' is a valid hostname and an invalid IPv4 or IPv6.
I think I'm gonna rollback to hostname and only hostname.

@n-rodriguez n-rodriguez added regression and removed question labels Jul 23, 2016

@n-rodriguez n-rodriguez added this to the v1.2.1 milestone Jul 23, 2016

n-rodriguez added a commit that referenced this issue Jul 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment