New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing mandatory param for partial repositories/download_revision #634

Merged
merged 1 commit into from Dec 30, 2016

Conversation

Projects
None yet
2 participants
@perltwiesekt

perltwiesekt commented Nov 29, 2016

Accessing "Archived repositorys" and trying to show specific repo leads to internal server error:

  Processing by ArchivedRepositoriesController#show as HTML
  Parameters: {"id"=>"loremipsum"}
  Current user: mkehl (id=6)
  Rendered plugins/redmine_git_hosting/app/views/common/_git_urls.html.haml (184.0ms)
  Rendered plugins/redmine_git_hosting/app/views/repositories/_show_top.html.haml (204.2ms)
  Rendered repositories/_navigation.html.erb (161.3ms)
  Rendered repositories/_breadcrumbs.html.erb (10.5ms)
  Rendered plugins/redmine_git_hosting/app/views/archived_repositories/_dir_list_content.html.erb (198.8ms)
  Rendered repositories/_dir_list.html.erb (207.9ms)
  Rendered repositories/_revision_graph.html.erb (17.0ms)
  Rendered plugins/redmine_git_hosting/app/views/archived_repositories/_revisions.html.erb (402.1ms)
  Rendered plugins/redmine_git_hosting/app/views/repositories/_download_revision.html.haml (605.5ms)
  Rendered plugins/redmine_git_hosting/app/views/archived_repositories/show.html.erb within layouts/base (2416.5ms)
Completed 500 Internal Server Error in 3842ms (ActiveRecord: 1059.9ms)

ActionView::Template::Error (undefined local variable or method `repository' for #<#<Class:0x007f5c24f03db8>:0x007f5c259941d8>):
    1: - if repository.downloadable?
    2:   - content_for :header_tags do
    3:     = bootstrap_load_module(:font_awesome)
    4: 

This means trying to render partial without mandatory param.

@n-rodriguez n-rodriguez merged commit ba7a9bd into jbox-web:devel Dec 30, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@n-rodriguez n-rodriguez self-assigned this Dec 30, 2016

@n-rodriguez n-rodriguez added the bugfix label Dec 30, 2016

@n-rodriguez n-rodriguez added this to the v1.2.2 milestone Dec 30, 2016

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Dec 30, 2016

Member

Thank you!

Member

n-rodriguez commented Dec 30, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment