Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken compilation when using cli #105

Open
wants to merge 5 commits into
base: master
from

Conversation

@thisdotrob
Copy link

thisdotrob commented Apr 3, 2019

Compiling using the cli with sibilant src/*.sibilant -o lib was
failing because the callback parameter to writeFile is no longer
optional as of Node v10.0.0

thisdotrob added 2 commits Apr 3, 2019
Compiling using the cli with 'sibilant src/*.sibilant -o lib' was
failing because the callback parameter to writeFile is no longer
optional as of Node v10.0.0
@thisdotrob thisdotrob force-pushed the GowerStreet:master branch from 27c8a44 to 9a80bb2 Apr 18, 2019
thisdotrob added 3 commits Apr 23, 2019
Using the repl was failing because the callback parameter to write is no
longer optional as of Node v10.0.0
This commit updates the transpiled JS to that produced by version
12.10.0 of node. We are committing these changes separately to avoid
muddying future diffs. We have also added lib/*.js files to the
.gitignore to reflect that these were not previously committed.
The transpiled output of the ternary macro previously lead to unexpected
behaviour when used within another expression such as string
concatenation. For example, when the following was transpiled and
evaluated as JavaScript, this previously produced an unexpected output
of "a" rather than the intended "prefix-a-suffix":

(+ "prefix- " (ternary true "a" "b") "-suffix")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.