Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases generator for ks_initial_IonTracks #22

Merged
merged 36 commits into from
Jul 27, 2022

Conversation

retkiewi
Copy link
Collaborator

@retkiewi retkiewi commented Jul 23, 2022

fixes #8
fixes #25

@retkiewi retkiewi linked an issue Jul 23, 2022 that may be closed by this pull request
@grzanka
Copy link
Collaborator

grzanka commented Jul 23, 2022

@retkiewi are you using the recent master branch? I am surprised that you could commit *pyc file despite having .gitignore

hadrons/functions.py Outdated Show resolved Hide resolved
hadrons/functions.py Outdated Show resolved Hide resolved
tests/ks_initial/test.py Outdated Show resolved Hide resolved
@grzanka
Copy link
Collaborator

grzanka commented Jul 23, 2022

@retkiewi start with testing of the simplest function, like single_track_PDEsolver (see

def single_track_PDEsolver(dict parameter_dic, dict extra_params_dic):
) instead of testing high level script like ks_initial_IonTracks or example_single_track.py

retkiewi and others added 3 commits July 23, 2022 17:12
Co-authored-by: Leszek Grzanka <grzanka@agh.edu.pl>
Co-authored-by: Leszek Grzanka <grzanka@agh.edu.pl>
Co-authored-by: Leszek Grzanka <grzanka@agh.edu.pl>
@retkiewi
Copy link
Collaborator Author

Currently, the tests are hanging on my machine (dunno why as of yet) and failing in the deployment pipeline (It doesn't see the compiled cython). #25 might fix the pipeline issue so I'm considering switching to that issue.

hadrons/functions.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
hadrons/functions.py Outdated Show resolved Hide resolved
hadrons/functions.py Outdated Show resolved Hide resolved
retkiewi and others added 2 commits July 26, 2022 18:56
Co-authored-by: Leszek Grzanka <grzanka@agh.edu.pl>
@retkiewi retkiewi marked this pull request as ready for review July 26, 2022 17:04
Copy link
Collaborator

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Owner

@jbrage jbrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jbrage jbrage merged commit 757ab00 into master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate compiling cython with setup.cfg Prepare an example validation script
3 participants