Another modification to support Redmine REST API #15

Merged
merged 1 commit into from Jun 18, 2012

Projects

None yet

3 participants

@NewAmsterdamIdeas

Here's another change I'd like to suggest, this time to the find() method. Currently the find() method supports adding an options string only in cases where the query is asking to get 'all'. However, Redmine's REST API has cases where it accepts an options string in cases where the query is asking to get a single ID. For example, when getting a Redmine "issue," there is an "include" option that tells the API to "fetch associated data (optional). Possible values: children, attachments, relations, changesets and journals."

http://www.redmine.org/projects/redmine/wiki/Rest_Issues

I don't think this change will break any existing functionality in the phpactiveresource library. It just adds a bit more flexibility.

@jbroadway
Owner

Agreed, a useful and unobtrusive change. Thanks again for these improvements!

@jbroadway jbroadway merged commit 4745379 into jbroadway:master Jun 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment