modifed find for: URL/plural.xml?someparam=1 #22

Merged
merged 3 commits into from Feb 1, 2013

Projects

None yet

2 participants

@jhirbour
Contributor
jhirbour commented Feb 1, 2013

I couldn't find a way to make PhpActiveResource search redmine for issues.

URL/plural.xml?someparam=1

(http://www.redmine.org/projects/redmine/wiki/Rest_Issues)

@jbroadway
Owner

I don't have a Redmine install to test, but it looks from the source like passing 'all' as the ID value does the same thing as false. Could we simply change the if ($id == 'all') { to if ($id == 'all' || $id == false) { and would that achieve the same thing?

@jhirbour
Contributor
jhirbour commented Feb 1, 2013

Ok I've changed my commit as you suggested.

@jbroadway
Owner

Thanks for the fix!

@jbroadway jbroadway merged commit e5efb70 into jbroadway:master Feb 1, 2013

1 check passed

default The Travis build passed
Details
@jhirbour jhirbour deleted the unknown repository branch Feb 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment