New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement summarizing from url #35

Merged
merged 3 commits into from May 24, 2017

Conversation

Projects
None yet
3 participants
@cacheflow
Copy link
Contributor

cacheflow commented May 16, 2017

-Allows a user to have an article summarized via URL.
-Included tests to ensure user passes a valid URL.
-Updated Readme to explain usage.

@jbrooksuk

This comment has been minimized.

Copy link
Owner

jbrooksuk commented May 22, 2017

Sorry for the delay in this!

I'm not sure if this really belongs at the package level. What do you think?

@fungilation

This comment has been minimized.

Copy link
Contributor

fungilation commented May 22, 2017

Ya, I do this outside of package as would almost anyone else to source text to summarize. async fetch() is great by itself

@cacheflow

This comment has been minimized.

Copy link
Contributor Author

cacheflow commented May 23, 2017

I thought it would nice to add since people do it outside of the package all the time.

@jbrooksuk jbrooksuk merged commit 9ab2ac9 into jbrooksuk:master May 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jbrooksuk

This comment has been minimized.

Copy link
Owner

jbrooksuk commented May 24, 2017

Thanks :)

@cacheflow

This comment has been minimized.

Copy link
Contributor Author

cacheflow commented May 26, 2017

Thanks! Could you also update this on NPM as well? I wanted to use it for a package I was working on. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment