Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Parsing complex custom types #15

Closed
daveriedstra opened this issue Oct 12, 2017 · 1 comment
Closed

Feature: Parsing complex custom types #15

daveriedstra opened this issue Oct 12, 2017 · 1 comment

Comments

@daveriedstra
Copy link

@daveriedstra daveriedstra commented Oct 12, 2017

This annotation

[TsType("MyType[]", "./my-type")]

currently results in this incorrect import

import { MyType[] } from "./my-type";

The results are similar with MyType?. The workaround is to manually import the type in the .ts file with a custom header and not specify an import in TsType. Since that's simple enough to do, this issue is a feature request for parsing in the TsType attribute.

jburzynski added a commit that referenced this issue Oct 14, 2017
@jburzynski
Copy link
Owner

@jburzynski jburzynski commented Oct 14, 2017

Should be fixed in 1.5.11. Fixed for arrays [], generic types <> and "?".

I haven't found information on what "?" after type name means in TypeScript. Do you mean MyType? or propertyName?: MyType ?

@jburzynski jburzynski closed this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants