Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move generation of the index file to the generator #25

Merged
merged 2 commits into from Jul 2, 2018

Conversation

Projects
None yet
2 participants
@stephtr
Copy link
Contributor

commented Jul 1, 2018

As suggested in #24.

/// </summary>
/// <param name="assemblies"></param>
/// <param name="skipCreateIndexFile">Wheter to ignore Options.CreateIndexFile</param>
public GenerationResult Generate(IEnumerable<Assembly> assemblies, bool skipCreateIndexFile)

This comment has been minimized.

Copy link
@jburzynski

jburzynski Jul 2, 2018

Owner

Can you give an example when you would use skipCreateIndexFile instead of setting Options.CreateIndexFile?
Edit: I just noticed I haven't added Options property to IGenerator - maybe that's what you mean? In this case, I would add Options { get; set; } to IGenerator instead of adding skipCreateIndexFile.

This comment has been minimized.

Copy link
@stephtr

stephtr Jul 2, 2018

Author Contributor

The problem was that calling Generate(IEnumerable<Assembly> assemblies) should generate an index file. That function calls GenerationResult Generate(Assembly assembly), which on itself should also create an index file, but we don't want to temporary recreate the index file for each assembly, if it nevertheless gets written at the end. But I just cleaned up that mess, it seems like yesterday I was too stressed.

This comment has been minimized.

Copy link
@jburzynski

jburzynski Jul 2, 2018

Owner

No problem, it's fine! :) I wanted to know what happens in the code essentially.

@jburzynski jburzynski merged commit 83b3793 into jburzynski:dev Jul 2, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jburzynski

This comment has been minimized.

Copy link
Owner

commented Jul 2, 2018

I'll do a release tomorrow or in 2 days, in case I/you realise that something needs to be changed. Right now you can use nuget packages (1.6.4) either from dev or dotnetcli branch.

@jburzynski

This comment has been minimized.

Copy link
Owner

commented Jul 5, 2018

TypeGen 1.6.4 is on NuGet, so you can use it 'normally' now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.