Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AssemblyResolver skipping nuget folders on macos and linux #28

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
2 participants
@sdamian
Copy link
Contributor

commented Sep 8, 2018

No description provided.

@sdamian sdamian force-pushed the sdamian:master branch from c5d76bf to d6fb2a1 Sep 8, 2018

@jburzynski jburzynski changed the base branch from master to dev Sep 10, 2018

@jburzynski jburzynski changed the base branch from dev to master Sep 10, 2018

@jburzynski jburzynski changed the base branch from master to dev Sep 10, 2018

@jburzynski jburzynski changed the base branch from dev to master Sep 10, 2018

@jburzynski

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2018

Thanks for your pull request! Can you pull request to dev instead of master? Thanks!

@sdamian sdamian changed the base branch from master to dev Sep 10, 2018

@sdamian sdamian force-pushed the sdamian:master branch from d6fb2a1 to 5b3e0fe Sep 10, 2018

@sdamian

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2018

Done

@sdamian

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2018

I have another one coming up with some more fixes ;)

@jburzynski

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2018

Great, I look forward to it! :) I really appreciate you making changes to make it cross-platform - to be honest, I didn't really predict anyone would use TypeGen cross-platform, therefore (as you probably noticed) the whole code is Windows-only. I'll look at the changes when I have a free moment. Also, please let me know - e.g. in a pull request comment etc. - whenever you finish making all cross-platform-related changes, so that I can release a new version with all fixes. Thanks again for the effort and I look forward to all and any improvements :)

@sdamian

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2018

This PR and #29 is all I have now regarding cross platform fixes. Plus a small cosmetic change in #30.
Looking forward to the next release 🤤

@jburzynski jburzynski merged commit 179fb04 into jburzynski:dev Sep 12, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jburzynski

This comment has been minimized.

Copy link
Owner

commented Sep 12, 2018

I just released 1.6.6 (should be listed in NuGet in a few moments). You can check if it works on linux/macos, in any case let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.