Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (slowly) trying to resolve missing assemblies over and over again #31

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@sdamian
Copy link
Contributor

commented Sep 24, 2018

Throwing an exception from AssemblyResolve causes the runtime to retry resolving the assembly (only to fail again) on the next occasion.
Given enough assemblies to resolve, several installed versions of the dotnet sdk and a lot of packages in the nuget cache, TypeGen would take minutes to complete/fail when assemblies are missing.

Returning null from AssemblyResolve when the assembly is not found (like described in https://docs.microsoft.com/en-us/dotnet/api/system.appdomain.assemblyresolve?view=netframework-4.7.2#remarks) leads to the expected behaviour (each assembly being resolved once).

@jburzynski jburzynski merged commit ad268ec into jburzynski:dev Sep 26, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

jburzynski added a commit that referenced this pull request Sep 26, 2018

@jburzynski

This comment has been minimized.

Copy link
Owner

commented Sep 26, 2018

Thanks for the PR! I just released version 1.6.7 - you can check if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.