Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting X-XSS-Protection Header #136

Merged
merged 5 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@OhHeyAlan
Copy link
Contributor

commented May 6, 2019

X-XSS-Protection sets the configuration for the cross-site scripting filters built into most browsers. The best configuration is "X-XSS-Protection: 1; mode=block".

Was "0"
Now "1; mode=block"

Correcting X-XSS-Protection Header
X-XSS-Protection sets the configuration for the cross-site scripting filters built into most browsers. The best configuration is "X-XSS-Protection: 1; mode=block".

Was "0"
Now "1; mode=block"
@jc21

This comment has been minimized.

Copy link
Owner

commented May 6, 2019

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-136-amd64

jc21 added some commits May 7, 2019

@jc21

This comment has been minimized.

Copy link
Owner

commented May 7, 2019

Can you please re-open this PR against the develop branch?

@OhHeyAlan OhHeyAlan changed the base branch from master to develop May 7, 2019

@OhHeyAlan

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@jc21 Done

@jc21

This comment has been minimized.

Copy link
Owner

commented May 7, 2019

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-136-amd64

@jc21

This comment has been minimized.

Copy link
Owner

commented May 8, 2019

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-136-amd64

@jc21

This comment has been minimized.

Copy link
Owner

commented May 8, 2019

Docker Image for build 4 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-136-amd64

@jc21 jc21 merged commit 4fad9d6 into jc21:develop May 8, 2019

12 checks passed

Build Develop Stage did not run due to when conditional
Details
Build Master Stage did not run due to when conditional
Details
Build PR Stage built successfully
Details
Develop Cleanup Stage did not run due to when conditional
Details
Develop Manifest Stage did not run due to when conditional
Details
Latest Cleanup Stage did not run due to when conditional
Details
Latest Manifest Stage did not run due to when conditional
Details
PR Cleanup Stage built successfully
Details
amd64 Stage did not run due to when conditional
Details
arm64 Stage did not run due to when conditional
Details
armv7l Stage did not run due to when conditional
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.