Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up lets Encrypt acme challenge config #165

Merged
merged 1 commit into from Jul 4, 2019

Conversation

Projects
None yet
2 participants
@the1ts
Copy link
Contributor

commented Jul 4, 2019

As discussed in Issue #135. Since Lets Encrypt don't publish IP ranges that their acme challenge service will be sourced from, we need to allow free access to this location special to override any IP ACLs added by Advanced Custom Nginx Configuration. Due to the way Nginx config is applied, this only applies to the regex and below, keeping the IP ACLs working for the rest of the website.

Open up lets Encrypt acme challenge config
Since Lets Encrypt don't publish IP ranges that their acme challenge service will be sourced from, we need to allow free access to this location special to override any IP ACLs added by Advanced Custom Nginx Configuration. Due to the way Nginx config is applied, this only applies to the regex and below, keeping the IP ACLs working for the rest of the website.
@jc21

This comment has been minimized.

Copy link
Owner

commented Jul 4, 2019

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-165-amd64

@jc21 jc21 merged commit ddbfdf6 into jc21:master Jul 4, 2019

9 checks passed

Build Develop Stage did not run due to when conditional
Details
Build Master Stage did not run due to when conditional
Details
Build PR Stage built successfully
Details
Develop Cleanup Stage did not run due to when conditional
Details
Develop Manifest Stage did not run due to when conditional
Details
Latest Cleanup Stage did not run due to when conditional
Details
Latest Manifest Stage did not run due to when conditional
Details
PR Cleanup Stage built successfully
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.