Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RtAssigneesTest.iteratesAssignees() sometimes fail #785

Closed
longtimeago opened this issue May 28, 2014 · 19 comments
Closed

RtAssigneesTest.iteratesAssignees() sometimes fail #785

longtimeago opened this issue May 28, 2014 · 19 comments

Comments

@longtimeago
Copy link
Contributor

Tests run: 3, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 1.025 sec <<< FAILURE! - in com.jcabi.github.RtAssigneesTest
iteratesAssignees(com.jcabi.github.RtAssigneesTest)  Time elapsed: 0.014 sec  <<< ERROR!
javax.validation.ConstraintViolationException: github can't be NULL
    at com.jcabi.aspects.aj.MethodValidator.validate(MethodValidator.java:181)
    at com.jcabi.aspects.aj.MethodValidator.beforeCtor(MethodValidator.java:116)
    at com.jcabi.github.RtUser.<init>(RtUser.java:92)
    at com.jcabi.github.RtAssignees$1.map(RtAssignees.java:96)
    at com.jcabi.github.RtAssignees$1.map(RtAssignees.java:93)
    at com.jcabi.github.RtValuePagination$Items.next(RtValuePagination.java:171)
    at org.hamcrest.collection.IsIterableWithSize.featureValueOf(IsIterableWithSize.java:21)
    at org.hamcrest.collection.IsIterableWithSize.featureValueOf(IsIterableWithSize.java:11)
    at org.hamcrest.FeatureMatcher.matchesSafely(FeatureMatcher.java:40)
    at org.hamcrest.TypeSafeDiagnosingMatcher.matches(TypeSafeDiagnosingMatcher.java:55)
    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:12)
    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
    at com.jcabi.github.RtAssigneesTest.iteratesAssignees(RtAssigneesTest.java:73)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:258)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:744)

This issue have concurrency nature, as single test passes 10 out of 10 times, but when running in a batch it fails 3 out of 7 times

@dmarkov
Copy link

dmarkov commented May 29, 2014

I'm aware of the task, give me some time to find a developer...

@dmarkov
Copy link

dmarkov commented May 29, 2014

@longtimeago thank you for the ticket reported, I topped your account for 15 mins, transaction 40160752

@dmarkov
Copy link

dmarkov commented May 29, 2014

@aistomin this ticket is yours now, please proceed, and keep in mind this. Any technical questions you should ask right here

@dmarkov
Copy link

dmarkov commented May 29, 2014

@aistomin Budget here is 30 mins (keep this principle in mind)

@aistomin
Copy link
Contributor

@longtimeago Could you help me to reproduce this error? You wrote: "but when running in a batch it fails 3 out of 7 times". I don't understand exactly what do you mean "batch"? I tried mvn clean install -Pqulice 10 times and didn't reproduce the bug. If you wrote about "concurrency nature" I suppose you somehow run it in several threads?
Also, as I see, you referenced this issue here: #786 with the words: "Also one test was ignored, as it become unstable." but as I see RtAssigneesTest.iteratesAssignees() isn't ignored but only RtAssigneesTest.checkUserIsNotAssigneeForRepo() is.

@longtimeago
Copy link
Contributor Author

@aistomin I can give a piece of advice. To locate the problem you can temporary add testNG to
project dependencies and use it's very useful annotation:

@Test(threadPoolSize = 3, invocationCount = 9,  timeOut = 10000)

@aistomin
Copy link
Contributor

@longtimeago Thank you for your help, I will try it.

@dmarkov
Copy link

dmarkov commented Jun 9, 2014

@aistomin check this "no obligations principle".. This task is on your name for at least 11 days. If you can't close it within the next 48 hours I'll have to assign someone else to it

@aistomin
Copy link
Contributor

aistomin commented Jun 9, 2014

@dmarkov unfortunately I can not continue working on this issue, could you re-assign it to someone else, please.

@yegor256
Copy link
Member

yegor256 commented Jun 9, 2014

@dmarkov please assign someone else

@dmarkov
Copy link

dmarkov commented Jun 9, 2014

@dmarkov please assign someone else

@yegor256 no problem, I'll try to find somebody else

@dmarkov
Copy link

dmarkov commented Jun 11, 2014

@carlosmiranda please proceed, it's yours

carlosmiranda added a commit to carlosmiranda/jcabi-github that referenced this issue Jun 12, 2014
@carlosmiranda
Copy link
Contributor

Fix submitted at pull request at #799, please review.

@carlosmiranda
Copy link
Contributor

@dmarkov we're waiting for #802.

carlosmiranda added a commit to carlosmiranda/jcabi-github that referenced this issue Jun 20, 2014
ghost pushed a commit that referenced this issue Jun 20, 2014
#799: pull request #785 RtAssigneesTest.iteratesAssignees() NotNull validation error fixed
@carlosmiranda
Copy link
Contributor

@longtimeago , #799 is merged, can we close this now?

@longtimeago
Copy link
Contributor Author

@carlosmiranda Sure, thank you!

@dmarkov
Copy link

dmarkov commented Jun 20, 2014

@carlosmiranda this task is in your hands for 10 days already

@carlosmiranda
Copy link
Contributor

@dmarkov , @yegor256 , why have I been deducted 5 points for this task for being late after it's been closed?

@dmarkov
Copy link

dmarkov commented Jun 22, 2014

@carlosmiranda 30 mins was added to your account, many thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants