New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#876 Upgraded to jcabi-http version 1.8 #878

Merged
merged 2 commits into from Jul 18, 2014

Conversation

Projects
None yet
4 participants
@carlosmiranda
Contributor

carlosmiranda commented Jul 18, 2014

A note about the revised unit tests - seems that jcabi-http 1.8 has a bug in its FakeRequest class: jcabi/jcabi-http#47. Instead of ignoring some affected tests, I revised them instead so that this task won't be blocked.

@dmarkov

This comment has been minimized.

Show comment
Hide comment
@dmarkov

dmarkov Jul 18, 2014

Thanks, someone will review your pull request soon

dmarkov commented Jul 18, 2014

Thanks, someone will review your pull request soon

@dmarkov

This comment has been minimized.

Show comment
Hide comment
@dmarkov

dmarkov Jul 18, 2014

@yegor256 could you please review this PR

dmarkov commented Jul 18, 2014

@yegor256 could you please review this PR

@yegor256

This comment has been minimized.

Show comment
Hide comment
@yegor256

yegor256 Jul 18, 2014

Member

@rultor good to merge

Member

yegor256 commented Jul 18, 2014

@rultor good to merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 18, 2014

Contributor

@rultor good to merge

@yegor256 OK, I'll try to merge. You can check the progress here

Contributor

rultor commented Jul 18, 2014

@rultor good to merge

@yegor256 OK, I'll try to merge. You can check the progress here

@rultor rultor merged commit f0c319d into jcabi:master Jul 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 18, 2014

Contributor

@rultor good to merge

@yegor256 done! FYI, full log is here (took me 5min)

Contributor

rultor commented Jul 18, 2014

@rultor good to merge

@yegor256 done! FYI, full log is here (took me 5min)

@dmarkov

This comment has been minimized.

Show comment
Hide comment
@dmarkov

dmarkov Jul 21, 2014

@yegor256 Thank you, I've added 20 mins to your account in payment/transaction "000-83daa0a0"

dmarkov commented Jul 21, 2014

@yegor256 Thank you, I've added 20 mins to your account in payment/transaction "000-83daa0a0"

@dmarkov

This comment has been minimized.

Show comment
Hide comment
@dmarkov

dmarkov Jul 21, 2014

@rultor please deploy

dmarkov commented Jul 21, 2014

@rultor please deploy

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 21, 2014

Contributor

@rultor please deploy

@dmarkov OK, I'll try to deploy now. You can check the progress here

Contributor

rultor commented Jul 21, 2014

@rultor please deploy

@dmarkov OK, I'll try to deploy now. You can check the progress here

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 21, 2014

Contributor

@rultor please deploy

@dmarkov Done! FYI, the full log is here (took me 4min)

Contributor

rultor commented Jul 21, 2014

@rultor please deploy

@dmarkov Done! FYI, the full log is here (took me 4min)

@carlosmiranda carlosmiranda deleted the carlosmiranda:876 branch Jul 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment