Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Set a Maven Property indicating if a database reused or created. #35
Find bugs "qulice" about too many methods. I refactored the "isOpen" out of this into a static class "SocketHelper" as it is a different concern. This alone wasn't enough though. After evaluating the rest of the class, I decided to ignore FindBugs, as the alternative would have been some nasty refactoring for the sake of it. I hope that is okay with you?
As previously discussed, "clean" is not final. Given this new feature it would make a lot of sense if it would be. To do so the Instance class needs to be refactored to set the properties in a constructor (rather than start method), unless you see a better way of doing this?
This of course will touch most of the other classes. I am happy to do this if you agree that this is the right thing to do, but have not yet done it as I wanted to keep the original change in its own commit and check with you if you are happy with the idea?