Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #16 Moved commons-io to test scope and migrated to TextResource #18

Merged
3 commits merged into from
Mar 14, 2014

Conversation

carlosmiranda
Copy link
Contributor

No description provided.

this(readAsString(uri.toURL()));
}

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use JavaDoc blocks for methods marked with @Override, see http://stackoverflow.com/questions/15905127/overridden-methods-in-javadoc

@yegor256
Copy link
Member

one small comment above

@carlosmiranda
Copy link
Contributor Author

@yegor256 , I pushed a new commit addressing your comment.

@yegor256
Copy link
Member

good to merge

@yegor256 yegor256 assigned ghost Mar 14, 2014
@yegor256
Copy link
Member

very clean and nice code, many thanks!

@ghost
Copy link

ghost commented Mar 14, 2014

Hey, let me try to merge your branch 16 from carlosmiranda/jcabi-xml into branch master of jcabi/jcabi-xml. If there won't be any merge conflicts, I'll try to build it. If it builds without errors, I will merge this pull request. I will let you know in any case, in a few...

@ghost
Copy link

ghost commented Mar 14, 2014

I've merged your branch 16 into master of jcabi/jcabi-xml without any merge conflicts. Then, I've built the code and found no problems. Thus, this pull request is accepted and will be merged in a few seconds.

$ Crontab `*/5 * * * *`  allowed execution
  SUCCESS 3ms
$ parallel  allowed with 1 thread(s)
  SUCCESS 33.1s
$ found 1 pull request(s) in Github
  SUCCESS 2.7s
$ 1 out of 1 request(s) approved
  SUCCESS 2.3s
$ merging request 18
   ?
$ notified GitHub pull request 18 that merging started
  SUCCESS 3.9s
$ EC2 `m1.small` instance `i-33cfd81d` created in `us-east-1a`
  SUCCESS 4.3s
$ uploaded `.ssh/config`
  SUCCESS 2min
$ uploaded `.ssh/id_rsa`
  SUCCESS 1.5s
$ chmod 600 ~/.ssh/id\_rsa
  SUCCESS 75ms
$ chmod 600 ~/.ssh/config
  SUCCESS 62ms
$ git clone ssh://git@github.com/carlosmiranda/jcabi-xml.git code
  SUCCESS 2.9s
$ cd code
  SUCCESS 23ms
$ git remote add dest ssh://git@github.com/jcabi/jcabi-xml.git
  SUCCESS 65ms
$ git remote update -p
  SUCCESS 472ms
$ git fetch
  SUCCESS 178ms
$ git checkout -b src origin/16
  SUCCESS 84ms
$ git checkout -b dest dest/master
  SUCCESS 100ms
$ git merge src
  SUCCESS 83ms
$ mvn help:system rultor:steps clean install -B -C -Pqulice >&2 1> >(col -b | tee -a ../log.txt) 2> >(col -b | tee -a ../log.txt >&2)
  SUCCESS 7min
$ maven-clean-plugin:clean
  SUCCESS 321ms
$ buildnumber-maven-plugin:create
  SUCCESS 3.6s
$ maven-resources-plugin:resources
  SUCCESS 513ms
$ maven-compiler-plugin:compile
  SUCCESS 15.1s
$ jcabi-maven-plugin:ajc
  SUCCESS 12.6s
$ maven-resources-plugin:testResources
  SUCCESS 95ms
$ maven-compiler-plugin:testCompile
  SUCCESS 6.0s
$ jcabi-maven-plugin:ajc
  SUCCESS 7.1s
$ maven-surefire-plugin:test
  SUCCESS 57.9s
$ jcabi-maven-plugin:versionalize
  SUCCESS 97ms
$ maven-jar-plugin:jar
  SUCCESS 997ms
$ maven-invoker-plugin:install
  SUCCESS 5.3s
$ maven-invoker-plugin:run
  SUCCESS 2min
$ qulice-maven-plugin:check
  SUCCESS 2min
$ jslint-maven-plugin:jslint
  SUCCESS 7.3s
$ maven-duplicate-finder-plugin:check
  SUCCESS 1.4s
$ xml-maven-plugin:validate
  SUCCESS 937ms
$ maven-install-plugin:install
  SUCCESS 134ms
$ EC2 instance `i-33cfd81d` terminated
  SUCCESS 5.9s
$ EC2 `m1.small` instance in `us-east-1a` costed $0.06
  SUCCESS 32ms
$ com.rultor.guard.github.GhRequest#accept()
   ?

ghost pushed a commit that referenced this pull request Mar 14, 2014
#18: pull request Issue #16 Moved commons-io to test scope and migrated to TextResource
@ghost ghost merged commit 4c6d2cb into jcabi:master Mar 14, 2014
carlosmiranda added a commit to carlosmiranda/jcabi-xml that referenced this pull request Apr 23, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants