Implementation of JPYC Python SDK #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@Mameta29 |
Mameta29
commented
Apr 9, 2025
| Returns: | ||
| HexBytes: トランザクションハッシュ | ||
| """ | ||
| ... |
Collaborator
Author
There was a problem hiding this comment.
日本語のコメントが混ざっているので英語で統一する
Collaborator
Author
There was a problem hiding this comment.
コメントが日本語になっているので英語 or 削除
| """ | ||
| return await asyncio.to_thread(func) | ||
|
|
||
| async def _execute_transaction(self, contract_fn: ContractFunction) -> HexBytes: |
Collaborator
Author
There was a problem hiding this comment.
エラーハンドリングの部分で、具体的なエラータイプを追加したほうがよいか。例えば InsufficientFundsError や GasLimitExceededError など。
Mameta29
commented
Apr 9, 2025
| self.web3 = get_web3_for_chain(chain_name, network_name, rpc_endpoint) | ||
| self.account = None | ||
|
|
||
| def create_private_key_account(self, private_key: Optional[str] = None) -> Optional[LocalAccount]: |
Collaborator
Author
There was a problem hiding this comment.
こちらは常にLocalAccountを返すので、戻り値の型をOptional[LocalAccount]ではなく単にLocalAccountにする
| @@ -0,0 +1,65 @@ | |||
| [tool.poetry] | |||
| name = "jpyc-sdk-python" | |||
| version = "1.0.0" | |||
Collaborator
Author
There was a problem hiding this comment.
このバージョンの書き方はnode sdkにならっている
Collaborator
|
一旦こちらの PR は閉じさせていただきます 🙇🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎨 Overview
Implementation of a Python SDK for interacting with JPYC tokens. This SDK provides interfaces to interact with JPYCv2 smart contracts across multiple chains including Ethereum, Polygon, Avalanche, and Astar.
🌈 Details
SDK implementation compatible with Python 3.11 and above
Smart contract integration using web3.py
Support for multiple chains (Ethereum, Polygon, Gnosis, Avalanche, Astar, Shiden, etc.)
Implementation of all API endpoints for JWT authentication and token operations
Unit test implementation and documentation generation
GitHub workflow configuration
📚 References
JPYCv2 Contracts
ERC-20 Specification
RetryClaude does not have internet access. Links provided may not be accurate or up to date.Claude can make mistakes. Please double-check responses.