[FIX] rentzsch#42 broken #import NSManagedObject.h codegen

jcarroll3 · Feb 27, 2013 · 3e60748 · 3e60748
1 parent dfe1e4b
commit 3e60748
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 4 deletions.
diff --git a/mogenerator.h b/mogenerator.h
@@ -19,6 +19,7 @@
 @end
 
 @interface NSEntityDescription (customBaseClass)
+- (BOOL)hasCustomClass;
 - (BOOL)hasSuperentity;
 - (BOOL)hasCustomSuperentity;
 - (NSString*)customSuperentity;

diff --git a/mogenerator.m b/mogenerator.m
@@ -54,13 +54,13 @@ - (NSArray*)entitiesWithACustomSubclassInConfiguration:(NSString*)configuration_
     nsenumerate (allEntities, NSEntityDescription, entity) {
         NSString *entityClassName = [entity managedObjectClassName];
 
-        if ([entityClassName isEqualToString:@"NSManagedObject"] || [entityClassName isEqualToString:@""] || [entityClassName isEqualToString:gCustomBaseClass]){
+        if ([entity hasCustomClass]){
+            [result addObject:entity];
+        } else {
             if (verbose_) {
                 ddprintf(@"skipping entity %@ (%@) because it doesn't use a custom subclass.\n", 
                          entity.name, entityClassName);
             }
-        } else {
-            [result addObject:entity];
         }
     }
 
@@ -77,6 +77,15 @@ - (BOOL)hasCustomBaseCaseImport {
 - (NSString*)baseClassImport {
     return gCustomBaseClassImport;
 }
+
+- (BOOL)hasCustomClass {
+    NSString *entityClassName = [self managedObjectClassName];
+    BOOL result = !([entityClassName isEqualToString:@"NSManagedObject"]
+        || [entityClassName isEqualToString:@""]
+        || [entityClassName isEqualToString:gCustomBaseClass]);
+    return result;
+}
+
 - (BOOL)hasSuperentity {
     NSEntityDescription *superentity = [self superentity];
     if (superentity) {
@@ -90,14 +99,15 @@ - (BOOL)hasCustomSuperentity {
     if (!forcedBaseClass) {
         NSEntityDescription *superentity = [self superentity];
         if (superentity) {
-            return YES;
+            return [superentity hasCustomClass] ? YES : NO;
         } else {
             return gCustomBaseClass ? YES : NO;
         }
     } else {
         return YES;
     }
 }
+
 - (NSString*)customSuperentity {
     NSString *forcedBaseClass = [self forcedCustomBaseClass];
     if (!forcedBaseClass) {

diff --git a/test/test.xcdatamodel/elements b/test/test.xcdatamodel/elements
diff --git a/test/test.xcdatamodel/layout b/test/test.xcdatamodel/layout