Observable cache, and fix for double use effect calls. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcblw
changed the title
… lifecycle subscriptions
jcblw
added a commit
that referenced
this pull request
Jan 23, 2023
* turn each query into an observable * hook up observable and to react client * trigger workflow * get tests working, and add awaited type * fix some of the types, with the data * add in cache policy * move types to root of client package * fix some test and properly resolve query promise * add in fetch first policy to the refetch * add in test for invalidation, and fix the issue with invalidation and lifecycle subscriptions * rename master to main
jcblw
added a commit
that referenced
this pull request
Jan 23, 2023
* turn each query into an observable * hook up observable and to react client * trigger workflow * get tests working, and add awaited type * fix some of the types, with the data * add in cache policy * move types to root of client package * fix some test and properly resolve query promise * add in fetch first policy to the refetch * add in test for invalidation, and fix the issue with invalidation and lifecycle subscriptions * rename master to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds many improvements around the cache and fixes double fetches in React 18. Some of the improvements are.
Testing
Additional notes
This is a breaking change, so I think it might be best to introduce some more breaks before merging this into the release.