Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export error messages encoding issues #279 #291

Open
wants to merge 1 commit into
base: master
from

Conversation

@sbihel
Copy link

sbihel commented Feb 14, 2018

A fix for issue #279. The bug is fully fixed compared to PR #283.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 14, 2018

Codecov Report

Merging #291 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files          49       49           
  Lines        6794     6794           
=======================================
  Hits         5733     5733           
  Misses       1061     1061
Impacted Files Coverage Δ
ftplugin/orgmode/plugins/Export.py 33.82% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce17a40...d53989a. Read the comment docs.

Copy link
Contributor

akstrfn left a comment

for consistent decoding use u_decode function from here file

@sbihel

This comment has been minimized.

Copy link
Author

sbihel commented Feb 14, 2018

u_decode does nothing for python3

@akstrfn

This comment has been minimized.

Copy link
Contributor

akstrfn commented Feb 14, 2018

I know :)

@sbihel

This comment has been minimized.

Copy link
Author

sbihel commented Feb 14, 2018

I am using python3 so it does not fix the bug 🤔 maybe it is more complex than I thought

@akstrfn

This comment has been minimized.

Copy link
Contributor

akstrfn commented Feb 14, 2018

I just checked this from my computer and not mobile and you are right u_decode is useless here. You solution should work.

@sbihel

This comment has been minimized.

Copy link
Author

sbihel commented Feb 19, 2018

Do I have to do anything more?

@akstrfn

This comment has been minimized.

Copy link
Contributor

akstrfn commented Feb 20, 2018

Nothing special, but I'd rewrite the map using a generator i.e. map(lambda x: x.decode(), p.communicate()) -> (x.decode() for x in p.communicate()). But that is just a preference 😄

@XVilka XVilka added this to the v0.6.1 milestone Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.