From 1303a30f32b01b6fac3684fa27e8dc78c1f11365 Mon Sep 17 00:00:00 2001
From: aboellinger <aboellinger@hotmail.com>
Date: Fri, 13 Nov 2020 19:40:06 +0100
Subject: [PATCH] Remove circular reference

`line_edit` was both the parent and the central widget of `searchWidget`,
causing a circular reference in the objects parenting (resulting in a segfault).
---
 NodeGraphQt/base/graph.py         | 24 ++++++++++++------------
 NodeGraphQt/widgets/tab_search.py |  2 +-
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/NodeGraphQt/base/graph.py b/NodeGraphQt/base/graph.py
index 1436ed6e..31dbaf48 100644
--- a/NodeGraphQt/base/graph.py
+++ b/NodeGraphQt/base/graph.py
@@ -72,7 +72,7 @@ class NodeGraph(QtCore.QObject):
     node_created = QtCore.Signal(NodeObject)
     """
     Signal triggered when a node is created in the node graph.
-    
+
     :parameters: :class:`NodeGraphQt.NodeObject`
     :emits: created node
     """
@@ -86,7 +86,7 @@ class NodeGraph(QtCore.QObject):
     node_selected = QtCore.Signal(NodeObject)
     """
     Signal triggered when a node is clicked with the LMB.
-    
+
     :parameters: :class:`NodeGraphQt.NodeObject`
     :emits: selected node
     """
@@ -94,7 +94,7 @@ class NodeGraph(QtCore.QObject):
     """
     Signal triggered when the node selection has changed.
 
-    :parameters: list[:class:`NodeGraphQt.NodeObject`], 
+    :parameters: list[:class:`NodeGraphQt.NodeObject`],
                  list[:class:`NodeGraphQt.NodeObject`]
     :emits: selected node, deselected nodes.
     """
@@ -109,19 +109,19 @@ class NodeGraph(QtCore.QObject):
     """
     Signal triggered when a node port has been connected.
 
-    :parameters: :class:`NodeGraphQt.Port`, :class:`NodeGraphQt.Port` 
+    :parameters: :class:`NodeGraphQt.Port`, :class:`NodeGraphQt.Port`
     :emits: input port, output port
     """
     port_disconnected = QtCore.Signal(Port, Port)
     """
     Signal triggered when a node port has been disconnected.
 
-    :parameters: :class:`NodeGraphQt.Port`, :class:`NodeGraphQt.Port` 
+    :parameters: :class:`NodeGraphQt.Port`, :class:`NodeGraphQt.Port`
     :emits: input port, output port
     """
     property_changed = QtCore.Signal(NodeObject, str, object)
     """
-    Signal is triggered when a property has changed on a node.  
+    Signal is triggered when a property has changed on a node.
 
     :parameters: :class:`NodeGraphQt.BaseNode`, str, object
     :emits: triggered node, property name, property value
@@ -129,7 +129,7 @@ class NodeGraph(QtCore.QObject):
     data_dropped = QtCore.Signal(QtCore.QMimeData, QtCore.QPoint)
     """
     Signal is triggered when data has been dropped to the graph.
-    
+
     :parameters: :class:`PySide2.QtCore.QMimeData`, :class:`PySide2.QtCore.QPoint`
     :emits: mime data, node graph position
     """
@@ -473,7 +473,7 @@ def viewer(self):
             by ``NodeGraphQt`` components.
 
         See Also:
-            :attr:`NodeGraph.widget` for adding the node graph into a 
+            :attr:`NodeGraph.widget` for adding the node graph into a
             :class:`PySide2.QtWidgets.QLayout`.
 
         Returns:
@@ -567,9 +567,9 @@ def undo_stack(self):
     def clear_undo_stack(self):
         """
         Clears the undo stack.
-        
+
         Note:
-            Convenience function to 
+            Convenience function to
             :meth:`NodeGraph.undo_stack().clear()`
 
         See Also:
@@ -1331,7 +1331,7 @@ def save_session(self, file_path):
     def load_session(self, file_path):
         """
         Load node graph session layout file.
-        
+
         Args:
             file_path (str): path to the serialized layout file.
         """
@@ -1341,7 +1341,7 @@ def load_session(self, file_path):
     def import_session(self, file_path):
         """
         Import node graph session layout file.
-        
+
         Args:
             file_path (str): path to the serialized layout file.
         """
diff --git a/NodeGraphQt/widgets/tab_search.py b/NodeGraphQt/widgets/tab_search.py
index 609acdac..17b09090 100644
--- a/NodeGraphQt/widgets/tab_search.py
+++ b/NodeGraphQt/widgets/tab_search.py
@@ -141,7 +141,7 @@ def __init__(self, node_dict=None):
         if self._node_dict:
             self._generate_items_from_node_dict()
 
-        searchWidget = QtWidgets.QWidgetAction(self.line_edit)
+        searchWidget = QtWidgets.QWidgetAction(self)
         searchWidget.setDefaultWidget(self.line_edit)
         self.addAction(searchWidget)
         self.setStyleSheet(STYLE_QMENU)