-
Notifications
You must be signed in to change notification settings - Fork 304
Quick fix for #207 #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick fix for #207 #209
Conversation
Move away from the deprecated QGLWidget and replace it with QOpenGLWidget This fixes the Wayland OpenGL issues described in #207 (in a very rough way)
|
As per inspection in gdb, it seems to correctly use OpenGL. |
|
I am still unhappy with the import: What if PyQt5 is used, but PySide2 is installed, too? I think this could likely cause problems. |
Judge which one to use according to Qt.IsPySide2 and Qt.IsPyQt5. |
|
@ArnoChenFx Cool, thanks. That's what I was looking for. |
Use Qt.IsPySide2 / Qt.IsPyQt5 rather than try/except
|
typo QGLWdiegt I wouldn't call it a quick and dirty fix, the docs for QGLWidget say:
So it's right to port away. I'm surprised you need the if statement, QOpenGLWidget has been there since 5.4 |
|
Sorry about the awkward typo.
I named it like this because I am very unfamiliar with Qt/OpenGL and do not know whether I really did it correctly. Perhaps I am missing some argument, context or whatever, so it should be carefully checked, although it seems to work for me. I don't want to create new issues by providing a botched fix.
That's probably because the Qt.py wrapper still supports PyQt4/PySide(1), see mottosso/Qt.py#341 |
|
@jchanvfx Could you please take a look? |
Move away from the deprecated QGLWidget and replace it with QOpenGLWidget
This is a very rough fix for the Wayland OpenGL issues described in #207