New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string format in czech locale #5

Closed
bklabs opened this Issue Apr 13, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@bklabs

bklabs commented Apr 13, 2015

Hi
I've faced with problem with decimal separator in czech locale - it is a "," but not "."
So, as result, "https://api.forecast.io/forecast/{0}/{1},{2}?units={3}&extend={4}&exclude={5}&lang={6}" will be formatted as "https://api.forecast.io/forecast/APIKEY/50,029,14,49?units=....."

workaround for now:

CultureInfo ci = Thread.CurrentThread.CurrentCulture;
Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture;
_forecast = await _forecastClient.GetWeatherDataAsync(_lat, _longt, units, language);
Thread.CurrentThread.CurrentCulture = ci;

Regards
Dmitry Belov

@jcheng31

This comment has been minimized.

Show comment
Hide comment
@jcheng31

jcheng31 Apr 16, 2015

Owner

Hey, thanks for reporting this. I'm looking into it now, and should be able to get a fix out soon - it looks like a fairly easy change, so it shouldn't take too long :)

Owner

jcheng31 commented Apr 16, 2015

Hey, thanks for reporting this. I'm looking into it now, and should be able to get a fix out soon - it looks like a fairly easy change, so it shouldn't take too long :)

@jcheng31 jcheng31 closed this in bea0059 Apr 16, 2015

@jcheng31

This comment has been minimized.

Show comment
Hide comment
@jcheng31

jcheng31 Apr 16, 2015

Owner

All right, I think that should fix it. I've published the change to NuGet, so you should be able to update through there - let me know if the issue's still there!

Owner

jcheng31 commented Apr 16, 2015

All right, I think that should fix it. I've published the change to NuGet, so you should be able to update through there - let me know if the issue's still there!

@bklabs

This comment has been minimized.

Show comment
Hide comment
@bklabs

bklabs Apr 16, 2015

Hi

GetWeatherDataAsync still does not work in Czech locale (

Regards

Dmitry Belov

bklabs commented Apr 16, 2015

Hi

GetWeatherDataAsync still does not work in Czech locale (

Regards

Dmitry Belov

@bklabs

This comment has been minimized.

Show comment
Hide comment
@bklabs

bklabs Apr 16, 2015

BTW

You can send a Culture directly as an argument in to string.Format method

Regards

D.

bklabs commented Apr 16, 2015

BTW

You can send a Culture directly as an argument in to string.Format method

Regards

D.

@jcheng31

This comment has been minimized.

Show comment
Hide comment
@jcheng31

jcheng31 Apr 17, 2015

Owner

Oops, I updated the time machine method but not the "main" one - my bad. I'll get to it in a bit.

Owner

jcheng31 commented Apr 17, 2015

Oops, I updated the time machine method but not the "main" one - my bad. I'll get to it in a bit.

@jcheng31

This comment has been minimized.

Show comment
Hide comment
@jcheng31

jcheng31 Apr 17, 2015

Owner

Alright, just made the change, added some simple tests, and published it. Let me know if it works :)

Owner

jcheng31 commented Apr 17, 2015

Alright, just made the change, added some simple tests, and published it. Let me know if it works :)

@bklabs

This comment has been minimized.

Show comment
Hide comment
@bklabs

bklabs Apr 17, 2015

Hi

It works! Thank you.

Regards

D.

bklabs commented Apr 17, 2015

Hi

It works! Thank you.

Regards

D.

@jcheng31

This comment has been minimized.

Show comment
Hide comment
@jcheng31

jcheng31 Apr 17, 2015

Owner

No problem :)

Owner

jcheng31 commented Apr 17, 2015

No problem :)

@jcheng31 jcheng31 closed this Apr 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment