Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

cinder availability zones api + list call implemented #581

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Contributor

inbarsto commented Oct 23, 2014

cinder availability zones api + list call implemented
fro PR #560

jclouds-pull-requests #1318 FAILURE
Looks like there's a problem with this pull request

jclouds » jclouds #1830 FAILURE
Looks like there's a problem with this pull request
(what's this?)

Contributor

jdaggett commented Oct 23, 2014

@inbarsto There is a Checkstyle failure on the import of the ZoneToEndpoint class. Also, I just noticed that we should move the AvailabilityZone and ZoneState classes to the org.jclouds.openstack.cinder.v1.domain package and delete the org.jclouds.openstack.cinder.v1.domain.zonescoped package.

Contributor

inbarsto commented Oct 23, 2014

i saw, fixed
fixing packages now

Contributor

inbarsto commented Oct 23, 2014

done

jclouds-pull-requests #1323 SUCCESS
This pull request looks good

jclouds-pull-requests #1324 SUCCESS
This pull request looks good

jclouds » jclouds #1835 SUCCESS
This pull request looks good
(what's this?)

jclouds » jclouds #1836 SUCCESS
This pull request looks good
(what's this?)

Owner

demobox commented Oct 24, 2014

Merged to master.

Uff. We got there!

@demobox demobox closed this Oct 24, 2014

Contributor

inbarsto commented Oct 24, 2014

thanks @demobox :)
and @jdaggett and @adriancole and god knows who else was on the original PR :)

@demobox demobox commented on the diff Oct 24, 2014

...k/cinder/v1/features/AvailabilityZoneApiLiveTest.java
+import static org.testng.Assert.assertTrue;
+
+@Test(groups = "live", testName = "AvailabilityZoneApiLiveTest", singleThreaded = true)
+public class AvailabilityZoneApiLiveTest extends BaseCinderApiLiveTest {
+
+ private AvailabilityZoneApi availabilityZoneApi;
+
+ public AvailabilityZoneApiLiveTest() {
+ super();
+ provider = "openstack-cinder";
+ }
+
+ @BeforeClass(groups = {"integration", "live"})
+ public void setupContext() {
+ super.setup();
+ String zone = Iterables.getFirst(api.getConfiguredZones(), "regionOne");
@demobox

demobox Oct 24, 2014

Owner

@inbarsto Just noticed: should this be api.getConfiguredRegions() on master? If so, I'll fix in a quick follow-up commit.

Contributor

inbarsto commented Oct 24, 2014

Yeah. Seems legit :)

Owner

demobox commented Oct 24, 2014

Yeah. Seems legit :)

Follow-up committed to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment