Cleanup imports in google-compute-engine project. #989

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@nelsonjr
Contributor

nelsonjr commented Aug 7, 2016

No description provided.

@andreaturli

This comment has been minimized.

Show comment Hide comment
@andreaturli

andreaturli Aug 7, 2016

Contributor

Thx @nelsonjr

could you please avoid to reorder the imports and remove only the unused? It's a bit hard to review this PR otherwise.

Contributor

andreaturli commented Aug 7, 2016

Thx @nelsonjr

could you please avoid to reorder the imports and remove only the unused? It's a bit hard to review this PR otherwise.

@nelsonjr

This comment has been minimized.

Show comment Hide comment
@nelsonjr

nelsonjr Aug 7, 2016

Contributor

Can we do in 2 steps then? :-) How about 2 separate commits, one for removing unused and another to reorder?

Contributor

nelsonjr commented Aug 7, 2016

Can we do in 2 steps then? :-) How about 2 separate commits, one for removing unused and another to reorder?

@nelsonjr

This comment has been minimized.

Show comment Hide comment
@nelsonjr

nelsonjr Aug 7, 2016

Contributor

Actually there is only 1 instance of unused import:
org.jclouds.googlecomputeengine.domain.NewTargetInstance.Builder;

All the order changes are merely moving them according to the rest of the project. Would that be okay?

Contributor

nelsonjr commented Aug 7, 2016

Actually there is only 1 instance of unused import:
org.jclouds.googlecomputeengine.domain.NewTargetInstance.Builder;

All the order changes are merely moving them according to the rest of the project. Would that be okay?

@nacx

This comment has been minimized.

Show comment Hide comment
@nacx

nacx Aug 8, 2016

Owner

Reordering it is very dependent on the IDE defaults, which are different in Eclipse and IDEA (the two most used by our contributors), so eventually we'll see imports moved back again. That's why we ask contributors to keep the order as-is, since we don't have an import order policy.

This said, I personally don't care much about import ordering, so feel free to merge/discard if that facilitates further contributions :)

Owner

nacx commented Aug 8, 2016

Reordering it is very dependent on the IDE defaults, which are different in Eclipse and IDEA (the two most used by our contributors), so eventually we'll see imports moved back again. That's why we ask contributors to keep the order as-is, since we don't have an import order policy.

This said, I personally don't care much about import ordering, so feel free to merge/discard if that facilitates further contributions :)

@nelsonjr

This comment has been minimized.

Show comment Hide comment
@nelsonjr

nelsonjr Aug 9, 2016

Contributor

Okay, in that case let's abandon this PR.

Contributor

nelsonjr commented Aug 9, 2016

Okay, in that case let's abandon this PR.

@nelsonjr nelsonjr closed this Aug 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment