Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera feed of samples does not work on Safari 11+ #26

Closed
brassaro opened this issue Jan 22, 2018 · 3 comments

Comments

@brassaro
Copy link

commented Jan 22, 2018

On Safari 11+, the samples provided do not work: the camera feed does not appear, and there is an exception on the console.
It seems like the function 'createOjectURL' is deprecated.

@jcmellado jcmellado added the bug label Jan 23, 2018
@jcmellado

This comment has been minimized.

Copy link
Owner

commented Jan 23, 2018

Sorry, I can not test on Safari 11.
Could you copy here the exception you are seeing on console?
WebRTC API was experimental when I started the project.
I'll try to update the examples with the new API (getUserMedia, URL, ...).

@jcmellado jcmellado self-assigned this Jan 23, 2018
@brassaro

This comment has been minimized.

Copy link
Author

commented Jan 29, 2018

Hi,
Sorry for the late answer. Here is the console error:
Unhandled Promise Rejection: TypeError: Type error
@createObjectURL
@successCallback
@promiseReactionJob

Sounds like the API has changed and now, instead of 'video.src = window.URL.createObjectURL(stream)', we need to use 'video.srcObject = stream'

jcmellado added a commit that referenced this issue Jan 29, 2018
@jcmellado

This comment has been minimized.

Copy link
Owner

commented Jan 29, 2018

Thanks, I have updated the examples.

Please let me know if they are working for you now.

@jcmellado jcmellado closed this Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.