Permalink
Browse files

Removed inappropriate test from regression test. It was specifically …

…intended

to generate an error by using .C from R to call elog in Postgres (which won't
work). Under R-1.6.2 it did generate a trappable error. However, under R-1.7.0
is causes a segfault in Postgres. I'm sure there are lots of ways we can crash
Postgres through inappropriate use of .C, but I don't think we need to test for
it.
  • Loading branch information...
1 parent ee99c4f commit 239dd25532b25f24fa03a1f3f8a0718f6d45c090 postgres committed Mar 15, 2003
Showing with 0 additions and 10 deletions.
  1. +0 −6 expected/plr.out
  2. +0 −4 sql/plr.sql
View
@@ -137,12 +137,6 @@ select mean('{1.23,1.31,1.42,1.27}'::_float8);
(1 row)
-- generates appropriate error message
-create or replace function elog() returns text as '.C("elog", 18, "err from R")' language 'plr';
-select elog() as error;
-NOTICE: Error in .C("elog", 18, "err from R") : C/Fortran function name not in load table
-
-ERROR: Caught an error calling R function
--- generates appropriate error message
create or replace function sprintf(text,text,text) returns text as 'sprintf(arg1,arg2,arg3)' language 'plr';
select sprintf('%s is %f feet tall', 'Sven', '7') as error;
NOTICE: Error in sprintf(arg1, arg2, arg3) : use format %s for character objects
View
@@ -71,10 +71,6 @@ create or replace function mean(_float8) returns float as '' language 'plr';
select mean('{1.23,1.31,1.42,1.27}'::_float8);
-- generates appropriate error message
-create or replace function elog() returns text as '.C("elog", 18, "err from R")' language 'plr';
-select elog() as error;
-
--- generates appropriate error message
create or replace function sprintf(text,text,text) returns text as 'sprintf(arg1,arg2,arg3)' language 'plr';
select sprintf('%s is %f feet tall', 'Sven', '7') as error;

0 comments on commit 239dd25

Please sign in to comment.