Support Options to useOnlyUTC in the mail header

[viggyprabhu]

This PR supports all changes needed to support useOnlyUTC option in jsmime Header. This way, we can now customize jsmime to only use UTC as its TimeZone in the mail header so that the user's location through the TimeZone info is not leaked through the mail header.

[viggyprabhu]

The PR is generated against random-fixes branch as that is supposed to have the latest code.

[viggyprabhu]

@jcranmer Any comments on how I can improve this PR?

[jcranmer]

The option is probably better named "hideDateTimezone". Also, your English is not grammatically correct here:

If true, then use the UTC time zone instead of the local time zone when emitting date values.

[No need to mention the second sentence]

Also, note that "time zone" is two words in English, not one, and that capitalization is reserved for acronyms or the first word of a sentence.

[jcranmer]

Some more general comments:

• This should be compressed into one commit, not two.
• There is a lot of random extra trailing whitespace. Make it go away.
• I'm picky about style. So try to make sure that you're following 80-char limits, and make sure that you insert the proper number of spaces in places: I don't like if (foo){ but instead want to see the text if (foo) {. Look around the file if you're confused about the style.
• Also, try to write proper English sentences in comments, complete with punctuation.

[viggyprabhu]

Thanks for all the feedback, I will fix the issues and incorporate the
changes and send a new PR.

On Saturday 26 September 2015 12:15 PM, Joshua Cranmer wrote:

Some more general comments:

• This should be compressed into one commit, not two.
• There is a lot of random extra trailing whitespace. Make it go away.
• I'm picky about style. So try to make sure that you're following
  80-char limits, and make sure that you insert the proper number of
  spaces in places: I don't like |if (foo){| but instead want to see
  the text |if (foo) {|. Look around the file if you're confused about
  the style.
• Also, try to write proper English sentences in comments, complete
  with punctuation.

—
Reply to this email directly or view it on GitHub
#2 (comment).