Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and address Maven dependency. #158

Closed
simsong opened this issue Apr 9, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@simsong
Copy link

commented Apr 9, 2019

Skein's build_java step generates an error if mvn is not in the search path:

skice-DEV-MASTER:hadoop$ python3 setup.py install
running install
running build_java
creating /mnt/home/hadoop/simsong/skein/skein/java
error: [Errno 2] No such file or directory: 'mvn': 'mvn'
skice-DEV-MASTER:hadoop$ mvn
-bash: mvn: command not found
skice-DEV-MASTER:hadoop$ 

If it is going to be required, ideally the script would test for it and give a sensible error if it is not present.

It would also be great of Skein could be installed even if Apache Maven is not present, since Maven is not in the Amazon Linux repo.

@jcrist

This comment has been minimized.

Copy link
Owner

commented Apr 9, 2019

Doing a maven install in a setup.py script is not something I'd feel comfortable doing - users should take ownership of where non-python tooling lives and having our setup.py guess where a user wants to put maven is just asking for trouble. The error message when mvn is missing could definitely be improved though.

As I mentioned in #157, you don't need to build skein local to your machine, you can just scp over the wheel and install it locally. It's just a python library with a bundled java jar - nothing is architecture or OS specific.

@simsong

This comment has been minimized.

Copy link
Author

commented Apr 9, 2019

I'm not asking you to do a maven install; I'm asking you to detect if maven is installed or not, and give a reasonable error message if it is not.

@jcrist

This comment has been minimized.

Copy link
Owner

commented Apr 9, 2019

The error message has been improved in #160. As far as documentation, please see https://jcrist.github.io/skein/develop.html for instructions on setting up a build environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.