Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpython compatibility #101

Closed
myint opened this issue Jul 3, 2012 · 3 comments
Closed

bpython compatibility #101

myint opened this issue Jul 3, 2012 · 3 comments
Milestone

Comments

@myint
Copy link
Member

myint commented Jul 3, 2012

Importing pep8 results in an exception when done in bpython.

$ bpython
>>> import pep8
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "pep8.py", line 1054, in <module>
    stdin_get_value = TextIOWrapper(sys.stdin.buffer, errors='ignore').read
AttributeError: readable

Same thing happens if bpython runs pep8.py directly.

$ bpython pep8.py 
Traceback (most recent call last):
  File "pep8.py", line 1054, in <module>
    stdin_get_value = TextIOWrapper(sys.stdin.buffer, errors='ignore').read
AttributeError: readable
@myint
Copy link
Member Author

myint commented Jul 3, 2012

It looks like this is probably a bpython bug (related to monkey patching of sys.stdin). Though it might be nice if pep8 only accessed sys.stdin if needed (when options.diff is used).

@florentx
Copy link
Contributor

florentx commented Jul 3, 2012

I guess it happens with bpython for Python 3 ?

@myint
Copy link
Member Author

myint commented Jul 4, 2012

Thanks.

smira pushed a commit to smira/pep8 that referenced this issue Jul 25, 2012
* upstream/master: (169 commits)
  Fix false positive E401; issue PyCQA#104.
  Add tests for issue PyCQA#100.
  Fix false positive for continuation line indentation when line contains comments. Closes PyCQA#100
  Fix issue with bpython. Closes PyCQA#101
  Back to development.
  Fix crash, and release 1.3.3; issue PyCQA#98.
  Release version 1.3.2.
  Add E902 errors for IOErrors; issue PyCQA#87.
  Update README.
  A little bit of rewording.
  Revert to the pre-1.2 behavior: --show-pep8 does not imply --first; issue PyCQA#89.
  Fix errors on E121 and E124; issue PyCQA#92.
  Add changelog entries for issue PyCQA#86 and issue PyCQA#91.
  Fix the default configuration path on Windows. Issue PyCQA#95.
  Back to development.
  Allow 'verbose' to be specified in the config file
  Clarify .pep can be located in any parent folder
  Show maximum length in "E501 line too long" error message
  Release version 1.3.1.
  Do not read the configuration when used as a module.
  ...

Conflicts:
	pep8.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants