New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use css variable for `.error` or fallback to red #386

Merged
merged 2 commits into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@DRSDavidSoft
Contributor

DRSDavidSoft commented Apr 17, 2018

I added a small bit of CSS which will allow us to specify the --error-color the same way we can specify --link-color.

I currently do this:

.cmder--terminal .error, .cmder--terminal .error div {
    color: var(--error-color) !important;
}

which is not the most ellegant way.

Oh BTW, sorry I couldn't run make before comitting, the uglifyjs binary kept spitting Error 137, which I couldn't figure out how to resolve.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 17, 2018

Coverage Status

Coverage remained the same at 80.917% when pulling c182d67 on DRSDavidSoft:patch-1 into 5fe22be on jcubic:devel.

coveralls commented Apr 17, 2018

Coverage Status

Coverage remained the same at 80.917% when pulling c182d67 on DRSDavidSoft:patch-1 into 5fe22be on jcubic:devel.

@jcubic

This comment has been minimized.

Show comment
Hide comment
@jcubic

jcubic Apr 18, 2018

Owner

Thanks for the PR can you modify jquery.terminal-src.css it's the source file and I will run make myself.

Owner

jcubic commented Apr 18, 2018

Thanks for the PR can you modify jquery.terminal-src.css it's the source file and I will run make myself.

@jcubic jcubic merged commit 8aba622 into jcubic:devel Apr 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 80.917%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment