Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use css variable for .error or fallback to red #386

Merged
merged 2 commits into from Apr 18, 2018
Merged

Conversation

@DRSDavidSoft
Copy link
Contributor

@DRSDavidSoft DRSDavidSoft commented Apr 17, 2018

I added a small bit of CSS which will allow us to specify the --error-color the same way we can specify --link-color.

I currently do this:

.cmder--terminal .error, .cmder--terminal .error div {
    color: var(--error-color) !important;
}

which is not the most ellegant way.

Oh BTW, sorry I couldn't run make before comitting, the uglifyjs binary kept spitting Error 137, which I couldn't figure out how to resolve.

@coveralls
Copy link

@coveralls coveralls commented Apr 17, 2018

Coverage Status

Coverage remained the same at 80.917% when pulling c182d67 on DRSDavidSoft:patch-1 into 5fe22be on jcubic:devel.

@jcubic
Copy link
Owner

@jcubic jcubic commented Apr 18, 2018

Thanks for the PR can you modify jquery.terminal-src.css it's the source file and I will run make myself.

@jcubic jcubic merged commit 8aba622 into jcubic:devel Apr 18, 2018
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants